Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ABW-2171] Always require image URLs to be sent as URLs #700

Closed
wants to merge 1 commit into from
Closed

[ABW-2171] Always require image URLs to be sent as URLs #700

wants to merge 1 commit into from

Conversation

kugel3
Copy link
Contributor

@kugel3 kugel3 commented Sep 1, 2023 •
edited by jira bot
Loading

Jira ticket: ABW-2171

Description

key_image_url in NFTs is currently expected to be a string (because that’s what the sandbox sends), but this is incorrect, we should only accept URL

PR submission checklist

  • I have tested account to account transfer flow and have confirmed that it works

CyonAlexRDX
CyonAlexRDX approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kugel3 kugel3 closed this Sep 1, 2023
@kugel3
Copy link
Contributor Author

kugel3 commented Sep 1, 2023

We do this instead: #704, and later sort it out properly.

@kugel3 kugel3 deleted the ABW-2171_Require-image-urls-to-be-urls branch September 1, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciek-rdx maciek-rdx maciek-rdx approved these changes

@CyonAlexRDX CyonAlexRDX CyonAlexRDX approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kugel3 @CyonAlexRDX @maciek-rdx