Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ABW-2051] NFT images not displaying #704

Merged
merged 3 commits into from
Sep 1, 2023
Merged

[ABW-2051] NFT images not displaying #704

merged 3 commits into from
Sep 1, 2023

Conversation

kugel3
Copy link
Contributor

@kugel3 kugel3 commented Sep 1, 2023 •
edited by jira bot
Loading

Jira ticket: ABW-2051 and also ABW-2134

Description

  • Improves appearance of NFT rows (linespacing in resource name)
  • Makes NFT key images display, including redirected ones (by allowing key_image_url to be a string)

Screenshot

image

PR submission checklist

  • I have tested account to account transfer flow and have confirmed that it works

@kugel3 kugel3 mentioned this pull request Sep 1, 2023
Closed
1 task
CyonAlexRDX
CyonAlexRDX approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kugel3 kugel3 merged commit 7445b00 into main Sep 1, 2023
@kugel3 kugel3 deleted the ABW-2051_NFT-images-not-displaying branch September 1, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciek-rdx maciek-rdx maciek-rdx approved these changes

@CyonAlexRDX CyonAlexRDX CyonAlexRDX approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kugel3 @CyonAlexRDX @maciek-rdx