Reschedule too early events #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weilbith
reviewed
Feb 21, 2022
There was a problem hiding this comment.
Just some nitpicks and a bigger discussion point (there no approval yet). But no critique to your work. Very good job. Simple and effective. 👍🏾
Not your fault: I hate the end-to-end test. It is incredibly long with 90% basic stuff the exact case doesn't care about (which comes at the very end).
The database schema defining the token network table defines the settle timeout column as an hex integer. The Python module interacting with the database as a regular number. In result the later read number is a different then the originally inserted one. This commit includes an unrelated autoformatting change.
karlb
added a commit
that referenced
this pull request
Feb 24, 2022
* adapt monitoring to use timestamps (#1144) * Reschedule too early events (#1152) * add automatic adaption of confirmations blocks When the user does not manually define a number of confirmation blocks for the PFS or MS and the chain is detected to be Arbitrum, it will automatically set the number to zero. On Arbitrum based chains there are no confirmation blocks necessary. * Stop trying scheduled events after TooEarlyExc When the scheduled event with the lowest timestamp fails with a TransactionTooEarlyException, then we know that all other events would do that, too. So there is no reason to continue executing scheduled events at the moment. * Reduce the retry frequency of scheduled events. We don't want to put too much load on the ETH-RPC node and risk getting blocked or rate limited. * Trigger CI for PRs on all branches This would have helped when working on the arbitrum branches. * chore: Deprecate support for python 3.7 * Test retry changes in test_reschedule_too_early_events * Ensure ordering of scheduled events. * fix usage of eth-tester import in production Importing anything from eth-tester does not work in production as it is a test dependency that is not available. In result the monitoring service was failing to start. The import was used to test if a failed update balance proof transaction should be retried or not. The challenge is that in test mode, web3 forwards eth-tester exceptions untouched. That is not the same in production mode. Thereby the error looks slightly different. But both are based on the BaseException class. So it is possible to just verify their error message without matching the exact error class. This bug got introduced with a recent feature implementation. Unfortunately the CI pipeline was not properly working, which allowed to introduce this mistake. Co-authored-by: Fernando Cezar <fernando@brainbot.com> Co-authored-by: Thore Strassburg <thore@weilbier.net> Co-authored-by: Paul Lange <palango@gmx.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1149