Merge arbitrum branch #1160
Merged
Merge arbitrum branch #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user does not manually define a number of confirmation blocks for the PFS or MS and the chain is detected to be Arbitrum, it will automatically set the number to zero. On Arbitrum based chains there are no confirmation blocks necessary.
When the scheduled event with the lowest timestamp fails with a TransactionTooEarlyException, then we know that all other events would do that, too. So there is no reason to continue executing scheduled events at the moment.
We don't want to put too much load on the ETH-RPC node and risk getting blocked or rate limited.
This would have helped when working on the arbitrum branches.
Codecov Report
@@ Coverage Diff @@
## master #1160 +/- ##
==========================================
+ Coverage 88.81% 88.95% +0.13%
==========================================
Files 43 44 +1
Lines 3461 3494 +33
Branches 493 498 +5
==========================================
+ Hits 3074 3108 +34
+ Misses 281 280 -1
Partials 106 106
Continue to review full report at Codecov.
|
weilbith
approved these changes
Feb 24, 2022
There was a problem hiding this comment.
I think you forgot this commit here.
As CI runs through successfully: optimistic approval after changes ✔️
Importing anything from eth-tester does not work in production as it is a test dependency that is not available. In result the monitoring service was failing to start. The import was used to test if a failed update balance proof transaction should be retried or not. The challenge is that in test mode, web3 forwards eth-tester exceptions untouched. That is not the same in production mode. Thereby the error looks slightly different. But both are based on the BaseException class. So it is possible to just verify their error message without matching the exact error class. This bug got introduced with a recent feature implementation. Unfortunately the CI pipeline was not properly working, which allowed to introduce this mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arbitrum changes have reached a consistent working state. Let's merge it into master to prevent further divergence.