Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .raidionics/ directory during install and uninstall for Windows #36

Merged
merged 5 commits into from
Apr 4, 2023

Conversation

andreped
Copy link
Member

@andreped andreped commented Mar 31, 2023

This is related to issue #5.

Note that this PR only adds the fix for Windows, but I believe this is most critical there as most of the users are on Windows.

Doing the same for Linux is likely bad practice as the .raidionics/ directory is likely created in the home directory (see this discussion).

For macOS, I'm really not sure if this makes sense, as deletion of app bundles are done in a very different way. The bundles themselves are essentially just folders which lie in /Applications or similar. Deleting them means to delete the folder and nothing more. There is a discussion regarding this here.

We should also consider creating the .raidionics/ directory in a different directory in the future. I believe the C:/Users/some-user/AppData/Local/ might be suitable, but not sure.

@andreped
Copy link
Member Author

Could be an idea to delete the .raidionics/ directory the first time the program is being launched, if there is a sensible way of catching that (before creating it again, that is).

@andreped
Copy link
Member Author

I highlighted it better that the user needs to delete the .raidionics/ directory themselves. If they forget, on Windows it should still be deleted, but for UNIX systems lets just hope they do this.

Again, as there is no natural way to delete the .raidionics/ directory for macOS, I would likely attempt to delete it during initial program launch.

@andreped
Copy link
Member Author

andreped commented Mar 31, 2023

I also cropped the GIF in the README.

@dbouget dbouget merged commit 10fd401 into raidionics:master Apr 4, 2023
@andreped andreped deleted the remove-dir branch April 4, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants