Revert unsafe initializer #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we please get at least the option to disable the initializer? |
Maybe something like |
Sounds good to me! |
lunks
force-pushed
the
chore/revert-unsafe-initializer
branch
2 times, most recently
from
db4938f
to
dd4df1a
Compare
lunks
force-pushed
the
chore/revert-unsafe-initializer
branch
from
2b0f436
to
bbb0bc8
Compare
lunks
force-pushed
the
chore/revert-unsafe-initializer
branch
from
bbb0bc8
to
c5c7349
Compare
lunks
force-pushed
the
chore/revert-unsafe-initializer
branch
from
c5c7349
to
426bb6c
Compare
Done. |
rpbaltazar
approved these changes
Nov 9, 2020
|
Thank you for looking at this @lunks! 👍 |
Thanks for merging it in! 🎉 Nice work keeping apartment up to date, we wouldn't be able to upgrade our app to Rails 6 without this. |
This was referenced Dec 15, 2020
Merged
rpbaltazar
added a commit
that referenced
this pull request
Dec 16, 2020
Prepare Release - 2.8.0 - Resolves #98 - Trying to generate an automatic changelog - #99 - Resolves #86 - Fixes seeding errors - #87 - Resolves #66 - Uses a transaction to create a tenant - #69 - Resolves #121 - Relaxes dependencies to allow rails 6.1 - #122 - Resolves #123 - When tests run in a transaction, new tenants in tests fail to create - #124 - Reverted unsafe initializer - #118
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #113, #39 and #53.
In development, after a hot reload from webpacker,
Apartment::Tenant.currentreverts to public probably to the issue explained in #113, resulting in an error in our code. We haven't had the issue in production like @fsateler, but in development it is pretty much all the time after a reload.Given this is a fork of the old apartment and the probably number one reason it exists is to support it forward (like Rails 6), I think it makes sense to keep the behaviour of the previous gem for now.