-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare Release - 2.8.0 #126
Conversation
rpbaltazar
commented
Dec 15, 2020
•
edited
Loading
edited
- Resolves Improve changelog automatic generation #98 - Trying to generate an automatic changelog - [#98] improve changelog automatic generation #99
- Resolves error running db:seed task #86 - Fixes seeding errors - [Resolves #86] error running db seed task #87
- Resolves Use a transaction for Apartment::Tenant.create #66 - Uses a transaction to create a tenant - [Resolves #66] Wrap tenant creation arount transaction #69
- Resolves Rails 6.1 compatibility #121 - Relaxes dependencies to allow rails 6.1 - Relaxes requirements on Rails to make it compatible with Rails 6.1 #122
- Resolves Tenant creation in transaction makes some test cases fail #123 - When tests run in a transaction, new tenants in tests fail to create - check if there is an open transaction #124
- Reverted unsafe initializer - Revert unsafe initializer #118
dacbaea
to
4e8c13d
Compare
You should add my PR to the list too, it was on |
@rpbaltazar I'd like to talk about the error when trying to create an already existent schema. The one that starts with:
Two things concern me on it:
|
I've picked them and added it to the development branch, else we'd have a bunch of unresolved conflicts. |
I looked at this and it seems to be a side consequence of failing to create the tenant. The Logger is rescuing all exceptions and logging all that output that you see, including the stack trace. https://api.rubyonrails.org/v5.1.7/classes/ActiveSupport/LogSubscriber.html#method-i-finish I'm curious about the tenant creation error. Is that on purpose for demoing the sql.active_error logging problems or something related to the current development branch? |
I mean, to the changelog. |
@lunks just to make sure, was this an expected error that you wanted to show me the log for or was an unexpected error and the log was just a side thing? |
The error is expected (my tenant already exists) but it's pretty bad to have it shown like that. I think we should solve the active record log issue and handle this error more gracefully so users don't panic when seeing it. |
all clear. I think that for the sake of moving forward, we can open a ticket to address this and in the meantime release the gem version that fixes the unsafe initializer, which seems a more concerning issue |
Feel free to do so! |