Test installer commands #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds testing infrastructure to test against multiple versions of Rails, including Rails `main` branch.
This adds test coverage for the shared behavior of the installer commands. The commands are tested against a freshly generated Rails app using the version of Rails that is currently loaded. Thus the installers can be tested with different versions of Rails in CI.
This adds test coverage for specific behavior of the `javascript:install:bun` command.
This adds test coverage for specific behavior of the `javascript:install:esbuild` command.
This adds test coverage for specific behavior of the `javascript:install:rollup` command.
This adds test coverage for specific behavior of the `javascript:install:webpack` command.
jonathanhefner
force-pushed
the
test-installer
branch
from
ea9f41d
to
be1afa7
Compare
jonathanhefner
commented
Jan 14, 2024
Comment on lines
-7
to
+8
| rails_version = ENV["RAILS_VERSION"] || "6.1.0" | ||
| gem "rails", "~> #{rails_version}" | ||
|
|
||
| gem "appraisal" | ||
| gem "rails", "~> 6.0.0" |
There was a problem hiding this comment.
This file defaulted the Rails version to 6.1, but the gemspec specifies 6.0. Which is correct? (Or do we want to jump to Rails 7.0?)
There was a problem hiding this comment.
I believe we should retain compatibility with 6.0.
Comment on lines
+8
to
+15
| ruby-version: | ||
| - "3.1" | ||
| - "3.2" | ||
| - "3.3" | ||
| gemfile: | ||
| - gemfiles/rails_7_0.gemfile | ||
| - gemfiles/rails_7_1.gemfile | ||
| - gemfiles/rails_main.gemfile |
There was a problem hiding this comment.
This only tests with Rails >= 7.0 and Ruby >= 3.1. I can add entries for Rails 6.0 and 6.1, and older versions of Ruby, but first I wanted to confirm which versions we want to support.
There was a problem hiding this comment.
I think it's fine to focus on these for now.
dhh
added a commit
that referenced
this pull request
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR looks large because this project currently has no testing infrastructure. The vast majority of LOC in this PR are from
GemfileandGemfile.lockfiles. I have split the PR into multiple commits to further clarify.This adds test coverage for the
javascript:install:bun,javascript:install:esbuild,javascript:install:rollup, andjavascript:install:webpackcommands. The commands are tested against a freshly generated Rails app using the version of Rails that is currently loaded. Thus the installer can be tested with different versions of Rails in CI.Infrastructure has been added to run tests against Rails 7.0, 7.1, and
mainbranch.This PR takes a different approach than rails/dartsass-rails#49 — instead of separate appraisals / gemfiles for Sprockets and Propshaft, this PR has tests that target each.