Test installer commands #182
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| name: CI | ||
| on: [push, pull_request] | ||
| jobs: | ||
| tests: | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| ruby-version: | ||
| - "3.1" | ||
| - "3.2" | ||
| - "3.3" | ||
| gemfile: | ||
| - gemfiles/rails_7_0.gemfile | ||
| - gemfiles/rails_7_1.gemfile | ||
| - gemfiles/rails_main.gemfile | ||
| continue-on-error: [ false ] | ||
|
|
||
| name: ${{ format('Tests (Ruby {0}, {1})', matrix.ruby-version, matrix.gemfile) }} | ||
| runs-on: ubuntu-latest | ||
| continue-on-error: ${{ matrix.continue-on-error }} | ||
|
|
||
| env: | ||
| BUNDLE_GEMFILE: ${{ matrix.gemfile }} | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Remove Gemfile lock | ||
| run: | | ||
| rm -f $BUNDLE_GEMFILE.lock | ||
|
|
||
| - name: Install Ruby | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: ${{ matrix.ruby-version }} | ||
| bundler-cache: true | ||
|
|
||
| - name: Run tests | ||
| run: | | ||
| bundle exec rake | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,6 @@ | ||
| /tmp/ | ||
| .byebug_history | ||
| *.gem | ||
|
|
||
| # Ignore Gemfile.lock files for Rails main branch. | ||
| /gemfiles/rails_main*.gemfile.lock |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| appraise "rails_7_0" do | ||
| gem "rails", "~> 7.0.0" | ||
| gem "propshaft" | ||
| end | ||
|
|
||
| appraise "rails_7_1" do | ||
| gem "rails", "~> 7.1.0" | ||
| gem "propshaft" | ||
| end | ||
|
|
||
| appraise "rails_main" do | ||
| gem "rails", github: "rails/rails", branch: "main" | ||
| gem "propshaft" | ||
| end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,9 +4,9 @@ git_source(:github) { |repo| "https://github.com/#{repo}.git" } | |
| # Specify your gem's dependencies in importmap-rails.gemspec. | ||
| gemspec | ||
|
|
||
| gem "appraisal" | ||
| gem "rails", "~> 6.0.0" | ||
|
Comment on lines
-7
to
+8
There was a problem hiding this comment. This file defaulted the Rails version to 6.1, but the gemspec specifies 6.0. Which is correct? (Or do we want to jump to Rails 7.0?) There was a problem hiding this comment. I believe we should retain compatibility with 6.0. |
||
| gem "sprockets-rails" | ||
| gem "sqlite3" | ||
|
|
||
| group :test do | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only tests with Rails >= 7.0 and Ruby >= 3.1. I can add entries for Rails 6.0 and 6.1, and older versions of Ruby, but first I wanted to confirm which versions we want to support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to focus on these for now.