Use phantomjs2 #2862
Closed
Use phantomjs2 #2862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshibuya
reviewed
Mar 31, 2017
| @@ -29,6 +29,8 @@ gemfile: | |||
|
|
|||
| services: | |||
| - mongodb | |||
| - mysql | |||
| - postgresql | |||
There was a problem hiding this comment.
Looks unrelated to PhantomJS, is this correct?
There was a problem hiding this comment.
nop, in fact on travis precise env (default) those services are loaded by default, but with trusty env (to have phantom2) we must list all service that have to be started
mshibuya
reviewed
Apr 30, 2017
.travis.yml
Outdated
| @@ -1,11 +1,8 @@ | |||
| dist: trusty | |||
|
|
|||
There was a problem hiding this comment.
You want to switch to trusty, why is this removed?
|
Closed, and re-opened #2873 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trustyenvironment ontravishas phantomjs2.0.0instead of1.9.3inprecise@see travis-ci/travis-ci#3225 (comment)