Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use phantomjs2 #2862

Closed
wants to merge 3 commits into from
Closed

Use phantomjs2 #2862

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e268d73
upgrade ci env to trusty
waghanza Mar 27, 2017
3ea261a
need to start mysql before tests
waghanza Mar 27, 2017
3e04342
list all travis services that has to run
waghanza Mar 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
dist: trusty

Copy link
Member

@mshibuya mshibuya Apr 30, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want to switch to trusty, why is this removed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're write. Kind a mess

language: ruby

before_install: gem install bundler

before_script:
- phantomjs --version
- cd spec/dummy_app
- bundle exec rake rails_admin:prepare_ci_env db:create db:migrate
- cd ../../
Expand Down Expand Up @@ -33,6 +30,7 @@ gemfile:
services:
- mongodb
- mysql
- postgresql
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks unrelated to PhantomJS, is this correct?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nop, in fact on travis precise env (default) those services are loaded by default, but with trusty env (to have phantom2) we must list all service that have to be started


sudo: false

Expand Down