-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reference using setuptools instead of pip internal #116
Conversation
Thanks for the information. There is a part in the test code that mocks |
user_only=False, | ||
) | ||
return [dist._dist for dist in dists] | ||
import pkg_resources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understood that it is better not to import functions from pip._internal
. However, this ported code seems to have the advantage of working in many user environments.
Will import pkg_resources
succeed in all user environments? For example, it seems to exist in pip._vendor.pkg_resources
.
Any hope in seeing a fix for this issue merged in? Using
|
@jpmn I haven't decided if I want to merge this PR or not. Please install the latest version of pip-licenses in your environment and see if it solves the error. # Update pip-licenses version to 3.5.3 or later
$ pip install -U pip-licenses |
I am using the latest version of Don't you experience the same behavior with more recent versions of |
This fix is required for many users, it is not acceptable to pin the pip version for a such long time. Is there road map to support pip >= 22? |
@worroc Who are "many users"? If this is about you, we need information about your environment. At least in my environment it is working with pip 22.x. $ pip-licenses --with-system
Name Version License
PTable 0.9.2 BSD License
botocore 1.21.53 Apache Software License
jmespath 0.10.0 MIT License
pip 22.2.2 MIT License
pip-licenses 3.5.3 MIT License |
This proposal was superseded by another excellent proposal that uses importlib_metadata. |
Issue: #113
Reference function using setuptools instead of pip internal function. Reference: pypa/pip#5243