Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Implement cleanup for jobs #1048

Merged
merged 1 commit into from
Jan 10, 2022
Merged

ci: Implement cleanup for jobs #1048

merged 1 commit into from
Jan 10, 2022

Conversation

mudler
Copy link
Contributor

@mudler mudler commented Jan 10, 2022

Fixes #631
Part of #939
Signed-off-by: Ettore Di Giacinto edigiacinto@suse.com

@mudler mudler force-pushed the runner_cleanup branch 2 times, most recently from fdd930f to f770fe9 Compare January 10, 2022 11:24
Copy link
Contributor

@Itxaka Itxaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Fixes #631

Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
@mudler
Copy link
Contributor Author

mudler commented Jan 10, 2022

ok, I'd go over and merge it as it seems to work, it cleans up also at the end of the job: https://github.com/rancher-sandbox/cOS-toolkit/runs/4760575912?check_suite_focus=true

@mudler mudler merged commit 5ce44a2 into master Jan 10, 2022
@mudler mudler deleted the runner_cleanup branch January 10, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

local runners need a better cleanup
2 participants