Grub refactor and other distros #1858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1858 +/- ##
==========================================
+ Coverage 75.29% 75.97% +0.68%
==========================================
Files 67 66 -1
Lines 6825 6915 +90
==========================================
+ Hits 5139 5254 +115
+ Misses 1315 1290 -25
Partials 371 371 ☔ View full report in Codecov by Sentry. |
kkaempf
requested changes
Nov 20, 2023
|
@kkaempf alright, orange flavor is finally added too. Now the test matrix is huge and, unfortunately, the macos environment we use is still flaky a bit, hence with such a big matrix is not rare that one or two tests fail. Retrying makes them pass. On the good side tests are easily reproducible on the local environment, hence if there is a non environment related issue we can easily reproduce it without the need of github actions. |
davidcassany
commented
Nov 21, 2023
davidcassany
force-pushed
the
grub_refactor_and_other_distros
branch
from
ce0ad86 to
21d62f5
Compare
1 task
|
Adding blocked label as I think we should sort #1856 first, as the two PR conflict and I do believe it is easier to rebase this PR than the other way round. |
davidcassany
force-pushed
the
grub_refactor_and_other_distros
branch
from
21d62f5 to
a27fd26
Compare
davidcassany
force-pushed
the
grub_refactor_and_other_distros
branch
2 times, most recently
from
73b41a4 to
8cf2973
Compare
This commit moves grub logic into its own bootloader interface. In addition it adds helper methods to find EFI binaries, kernel and initrd based on patterns. No longer a distro detection is required. It also sets an elemental criteria for those bootloader files. In fact first place to look at is /boot/efi/EFI/elemental, which gives a chance within the OS Dockerfile to prepare EFI binaries if default distro paths are not matching any of the default Elemental patterns. Kernel and initrd symlinks as /boot/vmlinuz and /boot/initrd are also created within the init command. This gives at build time more confidence that the kernel and initrd are set consistently with Elemental expectations. As part of the refactor BIOS firmware and MSDOS partition tables support is finally dropped. Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
…t and efi values respectively Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
davidcassany
force-pushed
the
grub_refactor_and_other_distros
branch
from
8cf2973 to
8576c3f
Compare
kkaempf
approved these changes
Nov 30, 2023
frelon
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new bootloader interface and provides a grub based implementation for it.
The grub implementation is moved to its own bootloader package and the implementation is refactor to not relay on distro detection anymore, but instead it searches the relevant files (efi image, shim, grub modules, etc.) based on path patterns. The search is done by trying to find a file matching the given pattern, first match wins.
In addition, in order to make the implementation even more flexible, the first path where elemental tries to fine bootloader artifacts is an elemental custom path (currently
/usr/lib/elemental/bootloader), this is giving us a chance to set or copy the bootloader artifacts we want into custom path within the Dockerfile to ensure elemental client will later be capable to find them at install time (see Ubuntu example).Finally the refactor also changes the init command to ensure the initramfs and kernel are set with the appropriate names in init phase. So we are certain init is consistent with the default grub setup.