Add target for rpi disk #1859
Merged
Add target for rpi disk #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frelon
force-pushed
the
build-disk-rpi
branch
2 times, most recently
from
5f557a8 to
9e1b93a
Compare
kkaempf
reviewed
Nov 21, 2023
kkaempf
reviewed
Nov 21, 2023
kkaempf
reviewed
Nov 21, 2023
kkaempf
reviewed
Nov 21, 2023
kkaempf
reviewed
Nov 21, 2023
kkaempf
reviewed
Nov 21, 2023
frelon
force-pushed
the
build-disk-rpi
branch
from
86a85d6 to
74e4a42
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1859 +/- ##
==========================================
+ Coverage 75.29% 75.30% +0.01%
==========================================
Files 67 67
Lines 6825 6828 +3
==========================================
+ Hits 5139 5142 +3
Misses 1315 1315
Partials 371 371 ☔ View full report in Codecov by Sentry. |
davidcassany
requested changes
Nov 23, 2023
cmd/build-disk.go
Outdated
| @@ -105,7 +105,8 @@ func NewBuildDisk(root *cobra.Command, addCheckRoot bool) *cobra.Command { | |||
| c.Flags().Bool("expandable", false, "Creates an expandable image including only the recovery image") | |||
| c.Flags().Bool("unprivileged", false, "Makes a build runnable within a non-privileged container, avoids mounting filesystems (experimental)") | |||
| c.Flags().VarP(imgType, "type", "t", "Type of image to create") | |||
| c.Flags().StringSliceP("cloud-init", "c", []string{}, "Cloud-init config files") | |||
| c.Flags().StringSliceP("cloud-init", "c", []string{}, "Cloud-init config files to include in disk") | |||
| c.Flags().StringSlice("build-hooks", []string{}, "Paths to cloud-init config files to run during build") | |||
There was a problem hiding this comment.
This rename is not enough, it should be adapted within the pkg/types/v1/config.go at DiskSpec definition too.
Note for later. I am also wondering if shouldn't we make this change consistent to all commands and then have install-hooks, upgrade-hooks, reset-hooks flags.
There was a problem hiding this comment.
Yep, I brought back the cloud-init-paths for now since it is needed for this PR to produce a bootable rpi disk.
I also think we should rework the hooks in a follow up PR 👍
frelon
force-pushed
the
build-disk-rpi
branch
from
d2360a1 to
1ba600d
Compare
This commit adds a flavor for tumbleweed raspberry pi image that uses a after-disk hook to copy firmware into the EFI partition. Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
frelon
force-pushed
the
build-disk-rpi
branch
from
1ba600d to
7e7703c
Compare
Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a flavor for tumbleweed raspberry pi image that uses a after-disk hook to copy firmware into the EFI partition.