Fix #461 && unify upgrade images #507
Conversation
Looks like we were not creating the destinatio dir for the extract so it was failing to upgrade. Removing the switch as its no longer neccesary Signed-off-by: Itxaka <igarcia@suse.com>
Unify upgrade images into a single test, extract image name and image version into vars to be reused. This will also help with CI as we cna only run 5 macos instances in parallel so reducing the number of workers to run the tests will speed up the full workflow Signed-off-by: Itxaka <igarcia@suse.com>
| @@ -165,7 +165,6 @@ upgrade() { | |||
| # FIXME: Define default /var/tmp as tmpdir_base in default luet config file | |||
| export XDG_RUNTIME_DIR=$temp_upgrade | |||
| export TMPDIR=$temp_upgrade | |||
| export LUET_PRIVILEGED_EXTRACT=true | |||
There was a problem hiding this comment.
that looks more like a regression, when I've tested this it was not failing to upgrade at all - but it succeeded in the upgrade - the failing aspect was vagrant ssh not working with pubkeys. If now it works without pubkeys (because we login with user/pass), doesn't necessarly mean its bug free in there :)
There was a problem hiding this comment.
Can you try to check if after an upgrade you can still ssh with the vagrant pubkeys?
There was a problem hiding this comment.
see here: #260 (comment) and #260 (comment)
My test was simply mimicking CI:
- install
- do upgrade (which succeeded, and I could boot just fine afterwards)
- try to vagrant ssh with a priv/pubkey that was previously there already (setted up via cloud-init)
There was a problem hiding this comment.
as mentioned on the issue we dont use vagrant keys AFAIK, when you do vagrant ssh it uses the user/pass in the vagrantfile
Maybe when it happened we were not using the ssh user/pass ?
There was a problem hiding this comment.
Indeed, original issue had vagrant using its own method for the ssh keys while this PR c3d5ba2#diff-225f3d44285006fdfb0e6a444342ca7f84f2b8f366ae15fa4360265b535be386 changed that to user/pass to avoid spending time in injecting the keys....
There was a problem hiding this comment.
FYI, this was failing without this patch still, so it should be valid. Doesn't fix #481 thought... :D
There was a problem hiding this comment.
yes that's why I'm asking to test this with ssh keys 🙂 the problem was not present by logging with user/pass, but it was there only while logging in via ssh keys...
|
superseeded by #509 |
Looks like we were not creating the destination dir for the extract so it
was failing to upgrade. Removing the switch as its no longer necessary.
Unify upgrade images into a single test, extract image name and image
version into vars to be reused.
Closes #481
Signed-off-by: Itxaka igarcia@suse.com