Fix 481 #509
Merged
Fix 481 #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 11, 2021 13:03
Using user/pass its cool but you know whats even cooler? using the key that we insert as a vagrant cos feature which persists across reboots and resets Signed-off-by: Itxaka <igarcia@suse.com>
Looks like becasue the dir we point unpack to doesnt exists **and** its has a parent that also doesnt exist the non privileged path on luet[0] just tries to create the parent but fails because its not recursive, i.e. doesnt create the parents as neccesary. Meanwhile when using the privileged path[1] the lib creates the destination and all the parents needed, thus this is not a privs issue but a library issue. It only appears when having that switch because it takes different paths to different libs to deal with this. Creating the expected dir before extracting works in both paths. [0] https://github.com/mudler/luet/blob/master/vendor/github.com/containerd/containerd/archive/tar.go#L231 [1] https://github.com/mudler/luet/blob/master/vendor/github.com/docker/docker/pkg/archive/archive.go#L942 Signed-off-by: Itxaka <igarcia@suse.com>
mudler
reviewed
Aug 11, 2021
| @@ -184,6 +183,8 @@ upgrade() { | |||
| else | |||
| echo "Upgrading from container image: $UPGRADE_IMAGE" | |||
| set -x | |||
| # unpack doesnt like when you try to unpack to a non existing dir | |||
| mkdir -p $upgrade_state_dir/tmp/rootfs || true | |||
There was a problem hiding this comment.
I'm cooking a 0.17.8 and this shouldn't be required anymore, but nevertheless is good to have! 👍
mudler
approved these changes
Aug 11, 2021
mudler
suggested changes
Aug 11, 2021
|
|
mudler
approved these changes
Aug 11, 2021
mudler
added a commit
that referenced
this pull request
Sep 6, 2021
A follow up of #509 Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
Merged
mudler
added a commit
that referenced
this pull request
Sep 6, 2021
* Disable privileged extract on cos-deploy A follow up of #509 Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com> * Bump cOS Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commits for more info
closes #481