Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup refactoring leftover #933

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Fixup refactoring leftover #933

merged 2 commits into from
Dec 6, 2021

Conversation

mudler
Copy link
Contributor

@mudler mudler commented Dec 6, 2021

STATE_NUM is not required, what we are targeting here is always the
first partition

Fixes #929

cc @bk201 @johnliu55tw

Signed-off-by: Ettore Di Giacinto edigiacinto@suse.com

@mudler
Fixup refactoring leftover
17b6fb8 
STATE_NUM is not required, what we are targeting here is always the
first partition

Fixes #929

Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
@mudler
Bump cOS
1d19965 
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
@mudler mudler mentioned this pull request Dec 6, 2021
Closed
@mudler mudler enabled auto-merge (squash) December 6, 2021 10:04
@mudler
Copy link
Contributor Author

mudler commented Dec 6, 2021 

  ERROR    Error: building direct image: Error met while extracting image: Failed saving image: write /var/tmp/luet/.docker_temp_082205491: no space left on device

@mudler
Copy link
Contributor Author

mudler commented Dec 6, 2021

Need to tackle #917 first, or this will never pass in our CI :(

@mudler mudler mentioned this pull request Dec 6, 2021
Closed
@mudler mudler merged commit 90f0423 into master Dec 6, 2021
@mudler mudler deleted the fixup_nvme branch December 6, 2021 14:35
@mudler
Copy link
Contributor Author

mudler commented Dec 6, 2021

after a restart worked, still #934 is relevant

mudler added a commit that referenced this pull request Dec 7, 2021
@mudler
Backport #933 to 0.21.2
17a1b65
mudler added a commit that referenced this pull request Dec 7, 2021
@mudler
Backport #933 to 0.21.2
12285f4 
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
@mudler mudler mentioned this pull request Dec 7, 2021
Merged
mudler added a commit that referenced this pull request Dec 7, 2021
@mudler
Backport #933 to 0.21.2
35614af 
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
mudler added a commit that referenced this pull request Dec 7, 2021
@mudler
Backport #938 and #933 to 0.21.2 (testrun)
80b6e3c 
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
mudler added a commit that referenced this pull request Dec 7, 2021
@mudler
Backport #938 and #933 to 0.21.2 (testrun)
1ee86c1 
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
@guangbochen guangbochen mentioned this pull request Dec 7, 2021
Closed
mudler added a commit that referenced this pull request Dec 7, 2021
@mudler
Backport #933 and #938 to 0.21.2 (#937)
9a66ed6 
* Backport #933 to 0.21.2

Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>

* Add udevadm settle and call part_probe in custom layout

Fixes #938

Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>

* Bump cOS

Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>

* Backport #938 to 0.21.2

Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Itxaka Itxaka Itxaka approved these changes

@davidcassany davidcassany Awaiting requested review from davidcassany

@dragonchaser dragonchaser Awaiting requested review from dragonchaser

Assignees
No one assigned
Labels
area/harvester
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom partitioning layout fails with NVMe
2 participants
@mudler @Itxaka