ci: add cleanup images plugin #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudler
force-pushed
the
cleanup_images
branch
2 times, most recently
from
ae14fc7 to
ef7505b
Compare
This was referenced Dec 6, 2021
mudler
force-pushed
the
cleanup_images
branch
from
6baf762 to
cb1aab6
Compare
|
Rebased on top of #935 |
mudler
force-pushed
the
cleanup_images
branch
from
62f9517 to
555d5d6
Compare
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
This breaks validation as ver-1 is lower than ver See: #923 Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
mudler
force-pushed
the
cleanup_images
branch
from
555d5d6 to
3a61a70
Compare
Itxaka
reviewed
Dec 6, 2021
Yes and no, I mean we definitely can delete all images after we finish building one package, the plugin is just a safeguard to avoid going to look at this again
Nope, we run 1 job building all images, rationale is explained #917 . we can split build into multiple, but that has other problems as well (starvation) |
Itxaka
approved these changes
Dec 6, 2021
|
I think with #278 we can disable the plugin and the cleanup, and just run it after the whole build.. but keeping it for now until we have self-hosted runners |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to free up space during build (related to #917 )