Fix roletemplate.rules validation, added standard k8s checks #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: extended field path with proper index information for validated rule chore: created unit tests for ValidateRules
note: possible superfluousness of CheckForVerbs
chore: regenerated main documentation file
JonCrowther
reviewed
Jan 29, 2024
note: drop/inline `validateFields` fix: fields paths reported for globalroles
JonCrowther
previously approved these changes
Jan 30, 2024
pmatseykanets
previously approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Q: Do we need/want to make any adjustments to corresponding integration tests?
@pmatseykanets Thank you for pointing me to this. |
andreas-kupries
dismissed stale reviews from pmatseykanets and JonCrowther
via
142fd5c
|
Integrations tests extended - role templates, and global roles. |
pmatseykanets
approved these changes
Feb 1, 2024
JonCrowther
approved these changes
Feb 1, 2024
This was referenced Feb 15, 2024
andreas-kupries
added a commit
to andreas-kupries/rancher-webhook
that referenced
this pull request
Mar 11, 2024
Proper validation of GlobalRole `rules`, plus fix (TomL) to make validation not namespaced.
This was referenced Mar 11, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
See rancher/rancher#40584
Problem
As described in the referenced issue, the roletemplate rules validation performs only a subset of the checks done by k8s on policy roles (besides the rancher-specific checks). In the referenced issue this is noted for
apiGroups. The same problem would happen for theresources. Theverbsfield is ok, because this is checked explicitly.Solution
The chosen solution calls on k8s functionality performing the entire set of rule checks for us.
The basic ability to do so was added with #309.
The core function for doing so,
validateRules, is moved out ofglobalroleinto thecommonpackage, to keep DRY.As part of this unit tests were added. The tests pass.
After this refactor the
roletemplatepackage is simply extended to call on this functionality.CheckList