Backport of PRs #328 and #332, plus go module refresh #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proper validation of GlobalRole `rules`, plus fix (TomL) to make validation not namespaced.
andreas-kupries
requested review from
a team,
pmatseykanets,
tomleb,
JonCrowther and
maxsokolovsky
pmatseykanets
approved these changes
Mar 11, 2024
JonCrowther
approved these changes
Mar 18, 2024
|
I think we should wait before merging this since we're in code freeze for 2.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Fix rancher/rancher#44356 ; backport the solution for rancher/rancher#40584
Original solution and a fix are PRs
Problem
See rancher/rancher#40584
Solution
See #328 and #332.
NamespacedRuleswas removed from the backport. This field is not present in the definition ofGlobalRoleused by the 0.4.x release series of webhook.CheckList