-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v0.4.6] s4: Fixes 227 #390
Merged
macedogm
merged 4 commits into
rancher:release/v0.4.6
from
pmatseykanets:v0.4.6-port-227
Jun 11, 2024
Merged
[v0.4.6] s4: Fixes 227 #390
macedogm
merged 4 commits into
rancher:release/v0.4.6
from
pmatseykanets:v0.4.6-port-227
Jun 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmatseykanets
requested review from
crobby,
tomleb,
JonCrowther,
andypitcher and
pdellamore
June 10, 2024 22:53
crobby
previously approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
pdellamore
approved these changes
Jun 10, 2024
macedogm
approved these changes
Jun 11, 2024
crobby
approved these changes
Jun 11, 2024
tomleb
approved these changes
Jun 11, 2024
pmatseykanets
pushed a commit
to pmatseykanets/webhook
that referenced
this pull request
Jun 17, 2024
* Validate user retention userattribute fields and settings (rancher#90) * [v0.4.s4] Don't allow empty lastLogin user attribute (rancher#97) * go mod tidy * Fix go.mod
pmatseykanets
added a commit
that referenced
this pull request
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Problem
Solution
CheckList