Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.4.6] s4: Fixes 227 #390

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

pmatseykanets
Copy link
Contributor

Issue:

Problem

Solution

CheckList

  • Test
  • Docs

@pmatseykanets pmatseykanets self-assigned this Jun 10, 2024
@pmatseykanets pmatseykanets requested a review from a team as a code owner June 10, 2024 22:52
crobby
crobby previously approved these changes Jun 10, 2024
Copy link
Contributor

@crobby crobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pmatseykanets pmatseykanets requested a review from crobby June 11, 2024 04:16
@macedogm macedogm merged commit ff98abd into rancher:release/v0.4.6 Jun 11, 2024
1 check passed
@pmatseykanets pmatseykanets deleted the v0.4.6-port-227 branch June 11, 2024 12:54
pmatseykanets pushed a commit to pmatseykanets/webhook that referenced this pull request Jun 17, 2024
* Validate user retention userattribute fields and settings (rancher#90)

* [v0.4.s4] Don't allow empty lastLogin user attribute (rancher#97)

* go mod tidy

* Fix go.mod
This was referenced Jun 17, 2024
pmatseykanets added a commit that referenced this pull request Jun 18, 2024
* Validate user retention userattribute fields and settings (#90)
* [v0.4.s4] Don't allow empty lastLogin user attribute (#97)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants