[v0.5] s4: Fixes 227 #404
Merged
[v0.5] s4: Fixes 227 #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpromislow
previously requested changes
Jun 17, 2024
There was a problem hiding this comment.
The PR fails because the drone config uses rancher/rancher:v2.9-head and that image quietly changed its base image from registry.suse.com/bci-base to bci-micro, and the latter doesn't include zypper .
I fixed this on other PRs that still use drone by moving it back to v2.9.0-alpha1
|
@ericpromislow Thanks for the insights! It seems like the required change is not related to this port in any way and should be applied is a separate PR. Then this one can be rebased. |
pmatseykanets
dismissed
ericpromislow’s stale review
The requested change has nothing to do with this port PR
|
Depends and needs to be rebased on #406 |
pmatseykanets
force-pushed
the
v0.5-port-227
branch
from
a089b27 to
d6e54d0
Compare
JonCrowther
approved these changes
Jun 17, 2024
raulcabello
approved these changes
Jun 18, 2024
| When a Setting is created, the following checks take place: | ||
|
|
||
| - If set, `disable-inactive-user-after` must be zero or a positive duration (e.g. `240h`). | ||
| - If set, `delete-inactive-user-after` must be zero or a positive duration (e.g. `240h`). |
There was a problem hiding this comment.
The MinDeleteInactiveUserAfter check does not seem to be documented. Is that intentional ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Port of #390
Problem
Solution
CheckList