Skip to content

Commit

Permalink
[makefile] define a do-nothing target for config.user (sonic-net#7483)
Browse files Browse the repository at this point in the history
Why I did it
After PR sonic-net#7344, 'make init' and/or 'make reset' will also build sonic slave dockers.

'-include rules/config.user' is supposed to be fine when the file is missing. However, when the file is missing, it generates a delayed error which later causes make init and make reset trying to build the sonic slave dockers.

How I did it
Define a do-nothing target for config.user to catch config.user build therefore preventing other builds to be triggered unexpectedly.

How to verify it
did make init and it is now only doing submodule init.
  • Loading branch information
yxieca authored and raphaelt-nvidia committed May 13, 2021
1 parent 71e6ca7 commit 01832e3
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions Makefile.work
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,11 @@ else
SLAVE_DIR = sonic-slave-jessie
endif

# Define a do-nothing target for rules/config.user so that when
# the file is missing, make won't try to rebuld everything.
rules/config.user:
@echo -n ""

include rules/config
-include rules/config.user

Expand Down

0 comments on commit 01832e3

Please sign in to comment.