[build] Extend rules/config.user to more Makefiles #7344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rules/config.user allows overriding default properties without touching tracked files. This change makes sure all properties can be set and not just the ones used in slave.mk. Signed-off-by: Christian Svensson <blue@cmd.nu>
|
@Staphylo: You did the initial addition of the config.user, what do you say about this addition? |
|
Not sure why |
|
That change looks good to me. I actually missed that Regarding the test runs, you'll have to wait for a project owner to restart the failed jobs. |
lguohan
approved these changes
Apr 16, 2021
|
now there is command like "/azpw run" to re-run the job now. |
This was referenced Apr 29, 2021
yxieca
added a commit
that referenced
this pull request
Apr 30, 2021
Why I did it After PR #7344, 'make init' and/or 'make reset' will also build sonic slave dockers. '-include rules/config.user' is supposed to be fine when the file is missing. However, when the file is missing, it generates a delayed error which later causes make init and make reset trying to build the sonic slave dockers. How I did it Define a do-nothing target for config.user to catch config.user build therefore preventing other builds to be triggered unexpectedly. How to verify it did make init and it is now only doing submodule init.
daall
pushed a commit
that referenced
this pull request
May 10, 2021
rules/config.user allows overriding default properties without touching tracked files. This change makes sure all properties can be set and not just the ones used in slave.mk. Signed-off-by: Christian Svensson <blue@cmd.nu>
daall
pushed a commit
that referenced
this pull request
May 10, 2021
Why I did it After PR #7344, 'make init' and/or 'make reset' will also build sonic slave dockers. '-include rules/config.user' is supposed to be fine when the file is missing. However, when the file is missing, it generates a delayed error which later causes make init and make reset trying to build the sonic slave dockers. How I did it Define a do-nothing target for config.user to catch config.user build therefore preventing other builds to be triggered unexpectedly. How to verify it did make init and it is now only doing submodule init.
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
rules/config.user allows overriding default properties without touching tracked files. This change makes sure all properties can be set and not just the ones used in slave.mk. Signed-off-by: Christian Svensson <blue@cmd.nu>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
Why I did it After PR sonic-net#7344, 'make init' and/or 'make reset' will also build sonic slave dockers. '-include rules/config.user' is supposed to be fine when the file is missing. However, when the file is missing, it generates a delayed error which later causes make init and make reset trying to build the sonic slave dockers. How I did it Define a do-nothing target for config.user to catch config.user build therefore preventing other builds to be triggered unexpectedly. How to verify it did make init and it is now only doing submodule init.
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
rules/config.user allows overriding default properties without touching tracked files. This change makes sure all properties can be set and not just the ones used in slave.mk. Signed-off-by: Christian Svensson <blue@cmd.nu>
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
Why I did it After PR sonic-net#7344, 'make init' and/or 'make reset' will also build sonic slave dockers. '-include rules/config.user' is supposed to be fine when the file is missing. However, when the file is missing, it generates a delayed error which later causes make init and make reset trying to build the sonic slave dockers. How I did it Define a do-nothing target for config.user to catch config.user build therefore preventing other builds to be triggered unexpectedly. How to verify it did make init and it is now only doing submodule init.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rules/config.user allows overriding default properties without
touching tracked files. This change makes sure all properties
can be set and not just the ones used in slave.mk.
Why I did it
I want to set
SONIC_CONFIG_USE_NATIVE_DOCKERD_FOR_BUILDwhich is read byMakefile.work.How I did it
I extended the existing functionality introduced in #5325.
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Extending functionality of
rules/config.userto include all build options.A picture of a cute animal (not mandatory but encouraged)