Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon hash for drupal 9.2 plus #556

Conversation

adfoster-r7
Copy link
Contributor

Description

Add latest favicon fingerprint hashes for drupal 9.2 plus

Motivation and Context

Add latest favicon fingerprint hashes for drupal 9.2 plus

How Has This Been Tested?

$ curl --silent https://raw.githubusercontent.com/drupal/drupal/10.1.x/core/misc/favicon.ico | md5sum | awk '{ print $1 }' | bin/recog_match xml/favicons.xml -
MATCH: {"matched"=>"Drupal CMS", "service.vendor"=>"Drupal", "service.product"=>"CMS", "service.certainty"=>"0.5", "service.cpe23"=>"cpe:/a:drupal:drupal:-", "service.protocol"=>"", "fingerprint_db"=>"favicon.md5", "data"=>"fe22dd2bb09daccf58256611ac491469"}

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@adfoster-r7 adfoster-r7 force-pushed the add-latest-favion-fingerprint-hashes-for-drupal-9.2-plus branch from 095fb3b to a244d24 Compare March 14, 2023 10:19
<description>Drupal CMS</description>
<!-- Original Drupal favicon https://github.com/drupal/drupal/blob/f0a16bf2a4d1524aa33b656533e37d977cca4802/core/misc/favicon.ico -->

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These extra lines have been added by bin/recog_cleanup -

gsub("-->", "-->\n") # Every comment should have an empty line after it

It looks a bit out of place to me 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's likely because most of the comment blocks are used to separate groupings of fingerprints. I'll have to see about additional customization in the cleanup changes.

@mkienow-r7 mkienow-r7 changed the title Add latest favicon fingerprint hashes for drupal 9.2 plus Add favicon hash for drupal 9.2 plus Mar 16, 2023
Copy link
Contributor

@mkienow-r7 mkienow-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @adfoster-r7!

@mkienow-r7 mkienow-r7 merged commit 476203d into rapid7:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants