Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon hash for drupal 9.2 plus #556

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Add favicon hash for drupal 9.2 plus #556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion xml/favicons.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,21 @@
<param pos="0" name="service.cpe23" value="cpe:/a:apache:tomcat:-"/>
</fingerprint>

<fingerprint pattern="^(?:b6341dfc213100c61db4fb8775878cec|cf2445dcb53a031c02f9b57e2199bc03)$">
<fingerprint pattern="^(?:b6341dfc213100c61db4fb8775878cec|cf2445dcb53a031c02f9b57e2199bc03|fe22dd2bb09daccf58256611ac491469)$">
<description>Drupal CMS</description>
<!-- Original Drupal favicon https://github.com/drupal/drupal/blob/f0a16bf2a4d1524aa33b656533e37d977cca4802/core/misc/favicon.ico -->

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These extra lines have been added by bin/recog_cleanup -

recog/bin/recog_cleanup

Line 11 in 0975a6c

gsub("-->", "-->\n") # Every comment should have an empty line after it

It looks a bit out of place to me 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's likely because most of the comment blocks are used to separate groupings of fingerprints. I'll have to see about additional customization in the cleanup changes.

<example>b6341dfc213100c61db4fb8775878cec</example>
<!--
High definition Drupal favicon
Drupal 8.0.0 https://github.com/drupal/drupal/blob/2ace26881d7a67a396caea6a79437c7e4e629f98/core/misc/favicon.ico
Drupal Bartik 9.2+ https://github.com/drupal/drupal/blob/cfa3a480fca997eaecdca2c81c8035ec61308abe/core/themes/bartik/favicon.ico
-->

<example>cf2445dcb53a031c02f9b57e2199bc03</example>
<!-- Drupal 9.2+ https://github.com/drupal/drupal/blob/cfa3a480fca997eaecdca2c81c8035ec61308abe/core/misc/favicon.ico -->

<example>fe22dd2bb09daccf58256611ac491469</example>
<param pos="0" name="service.vendor" value="Drupal"/>
<param pos="0" name="service.product" value="CMS"/>
<param pos="0" name="service.certainty" value="0.5"/>
Expand Down