Skip to content

Commit

Permalink
Fix to_pandas calls (#14552)
Browse files Browse the repository at this point in the history
This PR removes nullable=True in two pytests as we error when nullable is passed when there is decimal / list / struct data.
  • Loading branch information
galipremsagar authored Dec 5, 2023
1 parent e04b88b commit 29b3ac8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
1 change: 0 additions & 1 deletion python/cudf/cudf/tests/test_parquet.py
Original file line number Diff line number Diff line change
Expand Up @@ -2661,7 +2661,6 @@ def test_parquet_writer_decimal(decimal_type, data):
gdf.to_parquet(buff)

got = pd.read_parquet(buff, dtype_backend="numpy_nullable")
assert_eq(gdf.to_pandas(nullable=True), got)
assert_eq(gdf["val"].to_pandas(nullable=True), got["val"])
assert_eq(gdf["dec_val"].to_pandas(), got["dec_val"])

Expand Down
5 changes: 2 additions & 3 deletions python/cudf/cudf/tests/test_udf_masked_ops.py
Original file line number Diff line number Diff line change
Expand Up @@ -185,14 +185,13 @@ def func(row):
gdf["a"] = gdf["a"].astype(dtype_l)
gdf["b"] = gdf["b"].astype(dtype_r)

pdf = gdf.to_pandas(nullable=True)

pdf = gdf.to_pandas()
expect = op(pdf["a"], pdf["b"])
obtain = gdf.apply(func, axis=1)
assert_eq(expect, obtain, check_dtype=False)
# TODO: After the following pandas issue is
# fixed, uncomment the following line and delete
# through `to_pandas(nullable=True)` statement.
# through `to_pandas()` statement.
# https://github.com/pandas-dev/pandas/issues/52411

# run_masked_udf_test(func, gdf, nullable=False, check_dtype=False)
Expand Down

0 comments on commit 29b3ac8

Please sign in to comment.