Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to_pandas calls in pytests #14552

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Fix to_pandas calls in pytests #14552

merged 1 commit into from
Dec 5, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

This PR removes nullable=True in two pytests as we error when nullable is passed when there is decimal / list / struct data.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Dec 4, 2023
@galipremsagar galipremsagar self-assigned this Dec 4, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner December 4, 2023 05:12
@galipremsagar galipremsagar requested review from vyasr and removed request for a team December 4, 2023 05:12
@galipremsagar galipremsagar mentioned this pull request Dec 4, 2023
Closed
@github-actions github-actions bot added the Python Affects Python cuDF API. label Dec 4, 2023
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Dec 5, 2023
@galipremsagar galipremsagar merged commit 29b3ac8 into rapidsai:pandas_2.0_feature_branch Dec 5, 2023
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galipremsagar @mroeschke