Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Incorrect value for integers_to_hex reported in the function docs #14232

Closed
razajafri opened this issue Sep 28, 2023 · 1 comment · Fixed by #14208
Closed

[DOC] Incorrect value for integers_to_hex reported in the function docs #14232

razajafri opened this issue Sep 28, 2023 · 1 comment · Fixed by #14208
Assignees
Labels
doc Documentation

Comments

@razajafri
Copy link
Contributor

Report incorrect documentation

The value 123 should map to '7B' not '4D2' in the function docs for integers_to_hex.

Location of incorrect documentation

* s is [ '04D2', 'FFFFFFFF', '00', '1B', '146D7719']

Describe the problems or issues found in the documentation
It should be fixed to the correct hex value

Steps taken to verify documentation is incorrect
Ran the method integers_to_hex


Report needed documentation

Report needed documentation
A clear and concise description of what documentation you believe it is needed and why.

Describe the documentation you'd like
A clear and concise description of what you want to happen.

Steps taken to search for needed documentation
List any steps you have taken:

@davidwendt
Copy link
Contributor

I can fix this in #14208

rapids-bot bot pushed a commit that referenced this issue Oct 13, 2023
Removes support to convert BOOL8 column-type to hex using `cudf::strings::integers_to_hex`.
Also fixed other integer to string conversions to remove this unsupported type.
Added gtests to verify an error is thrown for this case.

Closes #14232

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Nghia Truong (https://github.com/ttnghia)
  - Karthikeyan (https://github.com/karthikeyann)
  - MithunR (https://github.com/mythrocks)

URL: #14208
@bdice bdice removed the Needs Triage Need team to review and classify label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants