-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return error if BOOL8 column-type is used with integers-to-hex #14208
Return error if BOOL8 column-type is used with integers-to-hex #14208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR makes me think of something similar to cudf::test::IntegralTypesNotBool
in the test module. Should we have something like this:
namespace cudf {
template<typename T>
bool constexpr is_integral_not_bool() {}
....
* @return false `T` is not integral or is bool | ||
*/ | ||
template <typename T> | ||
constexpr inline bool is_integral_not_bool() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, I could have sworn we had this already. (I think I'm confusing this with a type-list in the CUDF tests.)
Thanks for adding this.
/merge |
Description
Removes support to convert BOOL8 column-type to hex using
cudf::strings::integers_to_hex
.Also fixed other integer to string conversions to remove this unsupported type.
Added gtests to verify an error is thrown for this case.
Closes #14232
Checklist