Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error if BOOL8 column-type is used with integers-to-hex #14208

Merged
merged 14 commits into from
Oct 13, 2023

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Sep 27, 2023

Description

Removes support to convert BOOL8 column-type to hex using cudf::strings::integers_to_hex.
Also fixed other integer to string conversions to remove this unsupported type.
Added gtests to verify an error is thrown for this case.

Closes #14232

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 27, 2023
@davidwendt davidwendt self-assigned this Sep 27, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 4, 2023
@davidwendt davidwendt marked this pull request as ready for review October 4, 2023 17:46
@davidwendt davidwendt requested a review from a team as a code owner October 4, 2023 17:46
Copy link
Contributor

@ttnghia ttnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR makes me think of something similar to cudf::test::IntegralTypesNotBool in the test module. Should we have something like this:

namespace cudf {
template<typename T>
bool constexpr is_integral_not_bool() {}
....

* @return false `T` is not integral or is bool
*/
template <typename T>
constexpr inline bool is_integral_not_bool()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I could have sworn we had this already. (I think I'm confusing this with a type-list in the CUDF tests.)

Thanks for adding this.

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 6e00ad0 into rapidsai:branch-23.12 Oct 13, 2023
57 checks passed
@davidwendt davidwendt deleted the int-convert-without-bool branch October 13, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Incorrect value for integers_to_hex reported in the function docs
5 participants