Bump to nvcomp 3.0.6. #15128
Merged
Bump to nvcomp 3.0.6. #15128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
commented
Feb 23, 2024
Comment on lines
3051
to
3053
| # expect a failure when reading the whole file | ||
| with pytest.raises(RuntimeError): | ||
| cudf.read_parquet(fname) |
There was a problem hiding this comment.
TODO: This needs to be modified (I just don't have time at this moment). We probably want to read the file with another reader implementation and compare the results?
This will be testable after new nvcomp 3.0.6 packages are up.
There was a problem hiding this comment.
I verified that compute-sanitizer fails with nvcomp 3.0.5 and passes with nvcomp 3.0.6. This is indicative that the fix is good.
bdice
requested review from
wence- and
brandon-b-miller
and removed request for
a team
raydouglass
approved these changes
Feb 26, 2024
wence-
approved these changes
Feb 27, 2024
|
@raydouglass This should be good to go for the hotfix. All tests are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps nvcomp to 3.0.6. This is needed as a hotfix for #15096.
Depends on:
Checklist