Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to nvcomp 3.0.6. #346

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Feb 23, 2024

@bdice bdice mentioned this pull request Feb 23, 2024
3 tasks
@bdice bdice added bug Something isn't working non-breaking Introduces a non-breaking change labels Feb 26, 2024
@bdice bdice self-assigned this Feb 26, 2024
@bdice bdice marked this pull request as ready for review February 26, 2024 14:41
@bdice bdice requested a review from a team as a code owner February 26, 2024 14:41
common:
- output_types: conda
packages:
- cudf==24.2.*
Copy link
Contributor Author

@bdice bdice Feb 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were no references to cudf in the notebooks, so I removed this. This dependency was causing devcontainer builds to fail due to conflicting nvcomp versions. This has been a pain in the past because it introduced a circular dependency between kvikio and cudf, but it seems safe to remove now.

@bdice
Copy link
Contributor Author

bdice commented Feb 26, 2024

I checked the CI jobs and they used nvcomp==3.0.6. This should be good to go.

@raydouglass raydouglass merged commit a72a105 into rapidsai:branch-24.02 Feb 26, 2024
32 of 33 checks passed
raydouglass pushed a commit to rapidsai/cudf that referenced this pull request Feb 27, 2024
This PR bumps nvcomp to 3.0.6. This is needed as a hotfix for #15096.

Depends on:
- conda-forge/nvcomp-feedstock#14
- rapidsai/rapids-cmake#542
- rapidsai/kvikio#346

Authors:
   - Bradley Dice (https://github.com/bdice)

Approvers:
   - Lawrence Mitchell (https://github.com/wence-)
   - Ray Douglass (https://github.com/raydouglass)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants