Merge pull request #2 from JohnZed/enh-rf-acc-test

[WIP] Hack that makes accuracy tests (including python level) start passing
rapidsai · Mar 6, 2020 · 2398251 · 2398251
2 parents dbec815 + 5930a5d
commit 2398251
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/cpp/src/decisiontree/levelalgo/levelhelper_classifier.cuh b/cpp/src/decisiontree/levelalgo/levelhelper_classifier.cuh
@@ -297,7 +297,10 @@ void leaf_eval_classification(
   sparse_nodelist.clear();
 
   int non_leaf_counter = 0;
-  bool condition_global = (curr_depth == max_depth);
+  // XXX: This line fixes the inaccuracy in max_depth==1 tree leaf predictions
+  // I still don't fully understand its role, but it seems interesting
+  bool condition_global =
+    curr_depth >= max_depth - 1;  // XXX removed: (curr_depth == max_depth);
   if (max_leaves != -1)
     condition_global = condition_global || (tree_leaf_cnt >= max_leaves);