[REVIEW] Moving setup.py to project root for readthedocs.io #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
pushed a commit
that referenced
this pull request
Oct 3, 2019
Nyrio
pushed a commit
to Nyrio/cuml
that referenced
this pull request
Oct 22, 2019
Remove pointers-to-pointers in batched matrix kernels
JohnZed
pushed a commit
that referenced
this pull request
Jan 16, 2020
Merged
JohnZed
pushed a commit
that referenced
this pull request
Mar 6, 2020
[WIP] Hack that makes accuracy tests (including python level) start passing
Merged
venkywonka
added a commit
to venkywonka/cuml
that referenced
this pull request
Sep 16, 2020
venkywonka
added a commit
to venkywonka/cuml
that referenced
this pull request
Oct 12, 2020
jakirkham
pushed a commit
to jakirkham/cuml
that referenced
this pull request
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds of HTML for cuml.readthedocs.io are failing.
This is because sphinx, which generates the HTML, needs to be able to import the Python module to read the docstrings. cuML is pyx, which Sphinx can't naturally understand (at least as far as I've been able to figure out). As a result, the doc build setup as it stands needs to "python setup.py install" this library before docs can be built.
Unfortunately, readthedocs.io doesn't yet support configuring the environment to "cd ${subdir} && python setup.py install".
The workaround I came up with is to move setup.py to project root. Perhaps future build setup can either be more flexible, or the readthedocs configuration improvements let us move this back into the "python" subdirectory.