Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] - Adding example docstrings for cuML - PCA, TSVD, and DBSCAN algos #1

Merged
merged 10 commits into from
Oct 15, 2018
Merged

[REVIEW] - Adding example docstrings for cuML - PCA, TSVD, and DBSCAN algos #1

merged 10 commits into from
Oct 15, 2018

Conversation

randerzander
Copy link
Contributor

No description provided.

Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so far it looks good to me with one little comment

# The short X.Y version.
version = '0.0.1'
# The full version, including alpha/beta/rc tags.
release = '0.0.1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'alpha' status should be reflected here

@randerzander
Copy link
Contributor Author

@dantegd updated with fix for your version comment, added more doc-strings and convenience scripts for building the doc htmls.

@dantegd
Copy link
Member

dantegd commented Oct 15, 2018

Latest version looks good, merging.

@dantegd dantegd merged commit 35c04e7 into rapidsai:master Oct 15, 2018
cjnolet referenced this pull request in cjnolet/cuml Nov 15, 2018
dantegd pushed a commit that referenced this pull request Feb 27, 2019
venkywonka pushed a commit to venkywonka/cuml that referenced this pull request Jun 24, 2019
- indented comments properly
- avoided some implicit compiler issued typecasts
- refactored to adding the correct API declaration of the implementation in metrics.hpp
- refactored into using deviceAllocators wherever possible
- added `CUDA_CHECK(cudaStreamSynchronize(stream))` at suspected places
venkywonka pushed a commit to venkywonka/cuml that referenced this pull request Jul 4, 2019
- refactored code to avoid excess spacing
- avoided the raw numerically unstable computations of tanh and arctanh
- exposed the tanh and arctanh functions available in cuda toolkit to cuml
- removed redundant cudaStreamSynchronize statements
venkywonka pushed a commit to venkywonka/cuml that referenced this pull request Jul 11, 2019
- optimized all the kernels spanning each: AR, MA; for both transform and inverse transform; for all the 4 (p,q) values
cjnolet pushed a commit that referenced this pull request Jul 30, 2019
cjnolet pushed a commit that referenced this pull request Aug 8, 2019
cjnolet pushed a commit that referenced this pull request Oct 3, 2019
Nyrio pushed a commit to Nyrio/cuml that referenced this pull request Oct 22, 2019
Adding the KPSS stationarity test as a prim inside cuML
JohnZed pushed a commit that referenced this pull request Jan 16, 2020
@cjnolet cjnolet mentioned this pull request Feb 6, 2020
cjnolet pushed a commit that referenced this pull request Feb 24, 2020
Add serialization support to cuML's `Array`
JohnZed pushed a commit that referenced this pull request Mar 6, 2020
[WIP] Failing case for rf accuracy test
cjnolet pushed a commit that referenced this pull request Mar 13, 2020
…tests

[REVIEW] Adding pytest w/ explicit random seed.
dantegd pushed a commit that referenced this pull request Apr 30, 2020
venkywonka added a commit to venkywonka/cuml that referenced this pull request Sep 16, 2020
tfeher pushed a commit to tfeher/cuml that referenced this pull request Feb 9, 2022
rapids-bot bot pushed a commit that referenced this pull request Oct 25, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Mar 30, 2023
rapids-bot bot pushed a commit that referenced this pull request Jul 12, 2023
Merge latest commits from rapidsai/cuml: branch-23.06
rapids-bot bot pushed a commit that referenced this pull request Aug 3, 2023
Update dependencies.yaml test_notebooks to include dask_ml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants