[REVIEW] Naive Bayes #1375
Merged
[REVIEW] Naive Bayes #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
Cython / Python
…w we are going to accept distributed sparse arrays.
…to a `cuml.prims` package
…gh explicit conversion to rmm allocated GPU
|
@dantegd, I've addressed all your review feedback, if you have a moment for a quick re-review. I'm hoping we might be able to get this in tonight, if possible. |
cjnolet
added
3 - Ready for Review
|
rerun tests |
…ut how trustworthiness seems to be causing the test to fail.
dantegd
approved these changes
Feb 15, 2020
dantegd
added
5 - Ready to Merge
|
rerun tests |
|
rerun test |
|
rerun tests |
|
rerun tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, this PR was PyTorch-based and was going to be placed in an experimental package. I have since found cuPy's API for sparse by sparse matrix multiplication and have moved the implementation our of the experimental package.
This implementation is now 100% cupy-based. One of the downsides to having supported a PyTorch-based implementation is a known memory leak in DLPack.