Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Naive Bayes #1375

Merged
merged 108 commits into from
Feb 15, 2020
Merged

[REVIEW] Naive Bayes #1375

merged 108 commits into from
Feb 15, 2020

Commits on Nov 14, 2019

  1. Configuration menu
    Copy the full SHA
    690891e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4989010 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e80a6a7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    60dcd5f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d93be53 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d071fe3 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2019

  1. Getting closer

    cjnolet committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    a9e630f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cdc0239 View commit details
    Browse the repository at this point in the history
  3. Updating changelog

    cjnolet committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    e89e189 View commit details
    Browse the repository at this point in the history
  4. More style check fixes

    cjnolet committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    dd7d542 View commit details
    Browse the repository at this point in the history
  5. Style fixes

    cjnolet committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    8d0b3b8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8674cf7 View commit details
    Browse the repository at this point in the history
  7. turning print into assert

    cjnolet committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    4b6addf View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f1de912 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2019

  1. Configuration menu
    Copy the full SHA
    a99c1bd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    da5644d View commit details
    Browse the repository at this point in the history
  3. Removing prints

    cjnolet committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    ee175d9 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2019

  1. Configuration menu
    Copy the full SHA
    4bd6c56 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    214b723 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2019

  1. Checking in what I have for now. We need to get a better handle on ho…

    …w we are going to accept distributed sparse arrays.
    cjnolet committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    b3f5c8f View commit details
    Browse the repository at this point in the history
  2. Fixing silly typo in kernel

    cjnolet committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    4975dd6 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2019

  1. Profiling pytorch vs cupy

    cjnolet committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    c0b68b9 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2019

  1. Bunch of optimizations to NaiveBayes. Pulling a few custom kernels in…

    …to a `cuml.prims` package
    cjnolet committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    06a0703 View commit details
    Browse the repository at this point in the history
  2. Getting naive bayes to build

    cjnolet committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    cc4eac1 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2019

  1. Fixing label binarizer test

    cjnolet committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    c940335 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    df204ba View commit details
    Browse the repository at this point in the history
  3. Adding pytest for partial fit

    cjnolet committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    3555c60 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5ba7c2e View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2019

  1. Merge branch 'branch-0.11' into fea-ext-naive_bayes

    Conflicts:
    	CHANGELOG.md
    	python/cuml/dask/common/__init__.py
    cjnolet committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    326ebce View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2019

  1. Configuration menu
    Copy the full SHA
    7576f05 View commit details
    Browse the repository at this point in the history
  2. Matching sklearn exactly

    cjnolet committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    cbfffdd View commit details
    Browse the repository at this point in the history
  3. Updates to naive bayes

    cjnolet committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    bfd34e6 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2019

  1. Configuration menu
    Copy the full SHA
    e250e80 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2019

  1. Configuration menu
    Copy the full SHA
    f4135a0 View commit details
    Browse the repository at this point in the history
  2. Style fixes

    cjnolet committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    4212c7a View commit details
    Browse the repository at this point in the history
  3. Merge branch 'branch-0.12' into fea-ext-naive_bayes

    Conflicts:
    	python/cuml/dask/common/comms.py
    	python/cuml/test/dask/test_nearest_neighbors.py
    cjnolet committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    1242124 View commit details
    Browse the repository at this point in the history
  4. Updating tests

    cjnolet committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    09b3adf View commit details
    Browse the repository at this point in the history
  5. Some fixes to the dask naive bayes test. Needs to wait until the cupy…

    … vstack/hstack PR is merged, unfortunately
    cjnolet committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    3878d7a View commit details
    Browse the repository at this point in the history
  6. Adjusting order of parts

    cjnolet committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    5df09a8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c4ec31a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2b41a8f View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2019

  1. Configuration menu
    Copy the full SHA
    a04abee View commit details
    Browse the repository at this point in the history
  2. Moving some imports around

    cjnolet committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    fb1ad72 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2020

  1. Merge branch 'branch-0.12' into fea-ext-naive_bayes

    Conflicts:
    	CHANGELOG.md
    cjnolet committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    c622aa6 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'branch-0.12' into fea-ext-naive_bayes

    Conflicts:
    	CHANGELOG.md
    cjnolet committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    4407d64 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2020

  1. Configuration menu
    Copy the full SHA
    c8a559f View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2020

  1. Configuration menu
    Copy the full SHA
    2b3bdee View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    262520b View commit details
    Browse the repository at this point in the history
  3. Fixing style issues

    cjnolet committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    96ab54c View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2020

  1. A little cleanup

    cjnolet committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    04c432c View commit details
    Browse the repository at this point in the history
  2. Adding type generics to cupy rawkernel. Adding tests for different ty…

    …pes in naive bayes. Cleaning up naive bayes pytests
    cjnolet committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    abf9483 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    34215a0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    22acaa7 View commit details
    Browse the repository at this point in the history
  5. Fixing style issues

    cjnolet committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    d5c5f0a View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2020

  1. Configuration menu
    Copy the full SHA
    543eeea View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ddb4e25 View commit details
    Browse the repository at this point in the history
  3. Debugging dask errors in CI

    cjnolet committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    fccf4ab View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0752963 View commit details
    Browse the repository at this point in the history
  5. proper import this time.

    cjnolet committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    973994b View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2020

  1. Add pydocs for Naive Bayes & Distributed Naive Bayes

    Add score, predict_proba, predict_log_proba
    Add pytests for new functions.
    cjnolet committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    0260337 View commit details
    Browse the repository at this point in the history
  2. Fixing style issues

    cjnolet committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    19c2c99 View commit details
    Browse the repository at this point in the history
  3. Adding prims tests for classlabel prims

    Updating kernel factory to use proper pydoc format
    cjnolet committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    90e146e View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2020

  1. Configuration menu
    Copy the full SHA
    f346665 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2020

  1. Some umap fixes. Setting seed to 50 for now to isolate why results ar…

    …e still different. I believe it might be in the spectral clustering code, which doesn't provide a way to set a seed.
    cjnolet committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    1a5de48 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2020

  1. Some umap fixes. Setting seed to 50 for now to isolate why results ar…

    …e still different. I believe it might be in the spectral clustering code, which doesn't provide a way to set a seed.
    cjnolet committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    85e38f7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2b9c16b View commit details
    Browse the repository at this point in the history
  3. Naive Bayes tests are passing

    cjnolet committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    2e586dc View commit details
    Browse the repository at this point in the history
  4. Fixing style issues

    cjnolet committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    288fdf5 View commit details
    Browse the repository at this point in the history
  5. Fixing CI issues

    cjnolet committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    6ab84b3 View commit details
    Browse the repository at this point in the history
  6. Sparse dask array conversion utility is complete. Unfortunately, they…

    … cannot be computed until
    
    cupy supports vstack and hstack.
    cjnolet committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    2c092a6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c98a2c0 View commit details
    Browse the repository at this point in the history
  8. Removing support for sparse outputs in distributed label binarizer fo…

    …r now. will add back when it is fully supported
    cjnolet committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    a39b985 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    182e2b2 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    284a1b6 View commit details
    Browse the repository at this point in the history
  11. Fixing style issues

    cjnolet committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    c653529 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    121bd1c View commit details
    Browse the repository at this point in the history
  13. Style

    cjnolet committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    ddd3c1a View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2020

  1. Configuration menu
    Copy the full SHA
    4295deb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f9b7b13 View commit details
    Browse the repository at this point in the history
  3. Fixing cpp style errors

    cjnolet committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    7166137 View commit details
    Browse the repository at this point in the history
  4. More style errors

    cjnolet committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    8d8afc6 View commit details
    Browse the repository at this point in the history
  5. Updating copyrights to 2020

    cjnolet committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    daa432d View commit details
    Browse the repository at this point in the history
  6. Properly closing resources

    cjnolet committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    dbe1acd View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    361b01c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7b460ca View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ca34115 View commit details
    Browse the repository at this point in the history
  10. Referencing relevant issues

    cjnolet committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    31cc00e View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    229604e View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    7f33654 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    07193d4 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2020

  1. Configuration menu
    Copy the full SHA
    3ef383f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0e46380 View commit details
    Browse the repository at this point in the history
  3. Fixing style issues

    cjnolet committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    46abac4 View commit details
    Browse the repository at this point in the history
  4. Allowing naive bayes functions to take both host and gpu memory throu…

    …gh explicit conversion to rmm allocated GPU
    cjnolet committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    d8ed373 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ed88096 View commit details
    Browse the repository at this point in the history
  6. Patching local client as well

    cjnolet committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    986f00c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7482613 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    49b8761 View commit details
    Browse the repository at this point in the history
  9. Removing unused function.

    cjnolet committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    0163e39 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2020

  1. Small fixes

    cjnolet committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    cbe9c49 View commit details
    Browse the repository at this point in the history
  2. Fixing style issues

    cjnolet committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    5cd40c6 View commit details
    Browse the repository at this point in the history
  3. Commenting out trustworthiness in c++ test for now, until we figure o…

    …ut how trustworthiness seems to be causing the test to fail.
    cjnolet committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    29ebd7e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a8dcdd0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7948903 View commit details
    Browse the repository at this point in the history
  6. Fixing cpp style issues

    cjnolet committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    0c0a15c View commit details
    Browse the repository at this point in the history
  7. Adjusting thresholds for umap

    cjnolet committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    e293675 View commit details
    Browse the repository at this point in the history
  8. Style checking

    cjnolet committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    8542739 View commit details
    Browse the repository at this point in the history
  9. Lowering threshold again

    cjnolet committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    2183b4a View commit details
    Browse the repository at this point in the history