Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] link Logisitc MNMG via dask-glm demo to readme #3151

Merged
merged 7 commits into from
Nov 23, 2020

Conversation

daxiongshu
Copy link
Contributor

No description provided.

@@ -96,7 +96,7 @@ repo](https://github.com/rapidsai/notebooks-contrib).
| **Linear Models for Regression or Classification** | Linear Regression (OLS) | Multi-node multi-GPU via Dask |
| | Linear Regression with Lasso or Ridge Regularization | Multi-node multi-GPU via Dask |
| | ElasticNet Regression | |
| | Logistic Regression | |
| | Logistic Regression | Multi-node multi-GPU via Dask-GLM [demo](https://github.com/daxiongshu/rapids-demos) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any plans to push this notebook & readme to a RAPIDS repository? It would also be useful for users to provide a link to the Dask-GLM logistic regression docs / repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to push the notebook to notebooks-contrib but it seems that repo is under some changes so @JohnZed suggested to link my repo for now.

I'll add the link to dask-glm and documents in the readme of my repo. Thank you!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I support leaving it in a personal repo with a readme now until reorganizations in notebooks-contrib etc. are finalized so we don't have to keep moving around the link.

@cjnolet cjnolet changed the title Link dask glm demo to readme [REVIEW] Link dask glm demo to readme Nov 18, 2020
@cjnolet cjnolet added doc Documentation 3 - Ready for Review Ready for review by team 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Nov 18, 2020
@cjnolet
Copy link
Member

cjnolet commented Nov 18, 2020

@daxiongshu can you add an entry to the changelog for this change?

@cjnolet
Copy link
Member

cjnolet commented Nov 18, 2020

@ajschmidt8, I've fixed the conflict here. This is ready to merge when you have a moment.

@daxiongshu daxiongshu changed the title [REVIEW] Link dask glm demo to readme [REVIEW] link Logisitc MNMG via dask-glm demo to readme Nov 18, 2020
@ajschmidt8 ajschmidt8 merged commit 54fe7b3 into rapidsai:branch-0.17 Nov 23, 2020
@daxiongshu daxiongshu deleted the link_dask_glm_to_readme branch August 31, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge doc Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants