-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] link Logisitc MNMG via dask-glm demo to readme #3151
Merged
ajschmidt8
merged 7 commits into
rapidsai:branch-0.17
from
daxiongshu:link_dask_glm_to_readme
Nov 23, 2020
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cf87af4
Merge pull request #15 from rapidsai/branch-0.15
daxiongshu e3b7848
Merge pull request #18 from rapidsai/branch-0.17
daxiongshu e6d8ec3
Merge pull request #19 from rapidsai/branch-0.17
daxiongshu 7eb0a2e
add dask-glm demo link
daxiongshu 26a6715
add to changelog
daxiongshu e4f522d
Merge branch 'branch-0.17' into link_dask_glm_to_readme
cjnolet 0926d81
Merge branch 'branch-0.17' into link_dask_glm_to_readme
dantegd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any plans to push this notebook & readme to a RAPIDS repository? It would also be useful for users to provide a link to the Dask-GLM logistic regression docs / repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to push the notebook to
notebooks-contrib
but it seems that repo is under some changes so @JohnZed suggested to link my repo for now.I'll add the link to
dask-glm
and documents in the readme of my repo. Thank you!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I support leaving it in a personal repo with a readme now until reorganizations in notebooks-contrib etc. are finalized so we don't have to keep moving around the link.