Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploy condition in docs-publishing workflow (again) #181

Merged
merged 8 commits into from
Nov 7, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Nov 6, 2024

Contributes to #115

This should fix the issues we've been having with docs builds not triggering when we want them to. Specifically, only deploying the docs site on:

image

Notes for Reviewers

How I tested this

I've tried iterating here in this repo (see #176, #177, #178, #179, #180), but the feedback cycle is just too slow. So I created a personal repo just to test how GitHub Actions configuration like this works: https://github.com/jameslamb/gha-test

Found that the change introduced in this PR successfully implements the behavior we want.

@jameslamb jameslamb changed the title WIP: try fixing docs builds again Fix deploy condition in docs-publishing workflow (again) Nov 7, 2024
@jameslamb jameslamb marked this pull request as ready for review November 7, 2024 13:59
@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Nov 7, 2024
Copy link
Contributor

@seberg seberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, 🤞 that this works. The logic does look right to me, but then I never expected the older things to not do what we want either :).

@jameslamb
Copy link
Member Author

This is the one @seberg ! We have to believe! 😂

@jameslamb jameslamb merged commit ce72bbc into rapidsai:main Nov 7, 2024
9 checks passed
@jameslamb jameslamb deleted the ugh branch November 7, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants