Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploy condition in docs-publishing workflow (again) #181

Merged
merged 8 commits into from
Nov 7, 2024
Merged

Fix deploy condition in docs-publishing workflow (again) #181

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6890c8d
try this again
jameslamb Nov 6, 2024
79506b4
fix syntax
jameslamb Nov 6, 2024
fc5ba39
UGH
jameslamb Nov 6, 2024
f8c01a1
more syntax
jameslamb Nov 6, 2024
19e952b
more tests
jameslamb Nov 6, 2024
700edce
more changes
jameslamb Nov 6, 2024
bdcbf74
more checking
jameslamb Nov 6, 2024
a5165c9
fix condition
jameslamb Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,6 @@ jobs:
uses: ./.github/workflows/docs-build.yaml
with:
script: "ci/build_docs.sh"
# only deploy docs on tag pushes or when someone manually runs the workflow
deploy: ${{ github.event_name == 'tag' || inputs.deploy_docs == true }}
# only deploy docs on tag pushes or when someone manually runs the workflow with "update docs" selected
deploy: ${{ (github.event_name == 'push' && startsWith(github.ref, 'refs/tags')) || (github.event_name == 'workflow_dispatch' && inputs.deploy-docs == true) }}
secrets: inherit