Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rpi4 eth_led0 set to 4, amber light stays on #1311

Closed
LotusOttawa opened this issue Dec 30, 2019 · 19 comments
Closed

Rpi4 eth_led0 set to 4, amber light stays on #1311

LotusOttawa opened this issue Dec 30, 2019 · 19 comments
Assignees

Comments

@LotusOttawa
Copy link

Latest Rasbian on Pi4, eth_led0 setting to 4 does not function as documented. Amber LED stays on.

@JamesH65
Copy link
Contributor

Can you point to the docs that are wrong?

@LotusOttawa
Copy link
Author

@JamesH65
Copy link
Contributor

JamesH65 commented Jan 1, 2020

Just to confirm your changes are actually taking affect, do the other values do what you expect?

@JamesH65 JamesH65 self-assigned this Jan 1, 2020
@YiiRocks
Copy link

YiiRocks commented Jan 1, 2020

Using this is config.txt:

dtparam=act_led_trigger=heartbeat
dtparam=pwr_led_trigger=mmc0
dtparam=eth_led0=4
dtparam=eth_led1=4

The eth leds are both active (green blinking, amber constant), the others 2 are behaving as expected from the config.

@LotusOttawa
Copy link
Author

Is there a logfile to know if the changes take effect?

act_led_trigger=cpu works as it should but pwr_led_trigger=cpu keeps the LED on constantly

@pelwell
Copy link
Contributor

pelwell commented Jan 2, 2020

This issue is about the eth_led parameters - please create a new issue for any other LED parameter problems (they are likely to have a different cause).

sudo vcdbg log msg displays the logging output from the firmware, which might give provide a clue in the event of an error.

@YiiRocks
Copy link

YiiRocks commented Jan 2, 2020

002795.506: dtparam: act_led_trigger=heartbeat
002844.037: dtparam: pwr_led_trigger=mmc0
002892.686: dtparam: eth_led0=4
002905.456: Unknown dtparam 'eth_led0' - ignored
002905.548: dtparam: eth_led1=4
002918.307: Unknown dtparam 'eth_led1' - ignored

@pelwell
Copy link
Contributor

pelwell commented Jan 2, 2020

These parameters were only added in kernel 4.19.83 - if your kernel is older then you will have to update (or wait for the update to become available - I'm not sure which is the latest Raspbian kernel).

@YiiRocks
Copy link

YiiRocks commented Jan 8, 2020

Confirmed for me. Current kernel is version 4.19.75, upgrade to a version after .83 switched the lights off.

@LotusOttawa
Copy link
Author

I've now been able to upgrade to 4.19.93-v7l+

The eth_led0, eth_led1 Pi4 settings don't work as documented.

@pelwell
Copy link
Contributor

pelwell commented Jan 28, 2020

Show us your config.txt file.

@LotusOttawa
Copy link
Author

dtparam=eth_led0=4
dtparam=eth_led1=9

The comments are also hard to decipher (e.g. what's the difference between 0, 2, and 7?):

Pi4

                            0=Speed/Activity (default)       1=Speed
                            2=Speed/Flash activity   3=FDX
                            4=Off                    5=On
                            6=Alt                    7=Speed/Flash
                            8=Link                   9=Activity

@pelwell
Copy link
Contributor

pelwell commented Jan 28, 2020

With your settings the test Pi4 on my desk has the green LED off and the orange LED flashing with activity. What do you see?

The comments are also hard to decipher (e.g. what's the difference between 0, 2, and 7?):

My understanding is:

  • Speed means on for a fast link (probably 1Gb/s), otherwise off.
  • Activity inverts the current state for a short period for every packet, so more traffic means more flicker.
  • Flash activity is like Activity but without the proportionality - the pulses (which could be on or off depending on the other part of the mode) are a fixed width and the gaps are of (the same) minimum width, such that you see a clear flash pattern if there is activity and a steady state if not.

It looks like 2 is mislabelled and should just say Flash activity.

@JamesH65
Copy link
Contributor

The data we had on this was extremely sketchy - seems very likely I have got some terminology wrong in the docs.

@pelwell
Copy link
Contributor

pelwell commented Jan 28, 2020

The datasheet isn't at all clear.

@LotusOttawa
Copy link
Author

Ok, so according to pelwell's test, 'led_0' is green and 'led_1' is amber. Opposite to the 'usual' statement in the README file.

@pelwell
Copy link
Contributor

pelwell commented Jan 28, 2020

You haven't yet said what you observed, just that it didn't work "as documented". Are we talking about total failure or a few inconsistencies?

@LotusOttawa
Copy link
Author

LotusOttawa commented Jan 28, 2020

It's ok. 'led_0' is green and 'led_1' is amber.

pelwell pushed a commit to raspberrypi/linux that referenced this issue Jan 29, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
pelwell pushed a commit to raspberrypi/linux that referenced this issue Jan 29, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
pelwell pushed a commit to raspberrypi/linux that referenced this issue Jan 29, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
@pelwell
Copy link
Contributor

pelwell commented Jan 29, 2020

The overlay README has been updated - see raspberrypi/linux@f6e7d78.

popcornmix pushed a commit to raspberrypi/linux that referenced this issue Jan 30, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit to raspberrypi/linux that referenced this issue Jan 30, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix added a commit that referenced this issue Jan 30, 2020
See: raspberrypi/linux#3434

kernel: adds LED OFF feature to HiFiBerry DAC+ADC sound card
See: raspberrypi/linux#3435

kernel: adds LED OFF feature to HiFiBerry DAC+/DAC+PRO sound cards
See: raspberrypi/linux#3436

kernel: fix master mode settings of HiFiBerry DAC+ADC PRO card
See: raspberrypi/linux#3424

kernel: pisound: Added reading Pisound board hardware revision and exposing it
See: raspberrypi/linux#3425

kernel: Fix i2c-pwm-pca9685a overlay
See: raspberrypi/linux#3431

kernel: tty: amba-pl011: Add un/throttle support
kernel: tty: amba-pl011: Avoid rare write-when-full error
See: #1150

kernel: ARM: dts: Declare RPi 4B SD card power regulator

kernel: usb: xhci: Raspberry Pi FW loader for VIA VL805

kernel: overlays: Correct the eth_led* colour assignments
See: #1311

kernel: overlays: Remove hack from uart0 overlay
See: raspberrypi/linux#2856

kernel: ARM: dts: Add sd_poll_once dtparam to bcm283x/2711
See: raspberrypi/linux#3286

firmware: isp/tuner: Resetting to a lamp mode cancels manual_gains_used_

firmware: board_info: Fix uninitialised phy_addr handling in network boot

firmware: IL video_decode: Default to H264 as MPEG4 isn't supported

firmware: IL egl_render: Fail the create on Pi4

firmware: arm_dispmanx: Column pitch for YUV10COL is in lines not bytes

firmware: platform: 2711: Also add chicken bits to dvfs voltage

firmware: MMAL / video_render: Allow column stride to be set on column formats

firmware: vc_image/video_decode: Move +16 lines for di_adv from vc_image to decoder
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this issue Jan 30, 2020
See: raspberrypi/linux#3434

kernel: adds LED OFF feature to HiFiBerry DAC+ADC sound card
See: raspberrypi/linux#3435

kernel: adds LED OFF feature to HiFiBerry DAC+/DAC+PRO sound cards
See: raspberrypi/linux#3436

kernel: fix master mode settings of HiFiBerry DAC+ADC PRO card
See: raspberrypi/linux#3424

kernel: pisound: Added reading Pisound board hardware revision and exposing it
See: raspberrypi/linux#3425

kernel: Fix i2c-pwm-pca9685a overlay
See: raspberrypi/linux#3431

kernel: tty: amba-pl011: Add un/throttle support
kernel: tty: amba-pl011: Avoid rare write-when-full error
See: raspberrypi/firmware#1150

kernel: ARM: dts: Declare RPi 4B SD card power regulator

kernel: usb: xhci: Raspberry Pi FW loader for VIA VL805

kernel: overlays: Correct the eth_led* colour assignments
See: raspberrypi/firmware#1311

kernel: overlays: Remove hack from uart0 overlay
See: raspberrypi/linux#2856

kernel: ARM: dts: Add sd_poll_once dtparam to bcm283x/2711
See: raspberrypi/linux#3286

firmware: isp/tuner: Resetting to a lamp mode cancels manual_gains_used_

firmware: board_info: Fix uninitialised phy_addr handling in network boot

firmware: IL video_decode: Default to H264 as MPEG4 isn't supported

firmware: IL egl_render: Fail the create on Pi4

firmware: arm_dispmanx: Column pitch for YUV10COL is in lines not bytes

firmware: platform: 2711: Also add chicken bits to dvfs voltage

firmware: MMAL / video_render: Allow column stride to be set on column formats

firmware: vc_image/video_decode: Move +16 lines for di_adv from vc_image to decoder
popcornmix pushed a commit to raspberrypi/linux that referenced this issue Feb 6, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit to raspberrypi/linux that referenced this issue Feb 6, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit to raspberrypi/linux that referenced this issue Mar 23, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit to raspberrypi/linux that referenced this issue Mar 23, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit to raspberrypi/linux that referenced this issue Mar 27, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit to raspberrypi/linux that referenced this issue Mar 27, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit to raspberrypi/linux that referenced this issue Apr 1, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit to raspberrypi/linux that referenced this issue Apr 1, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit to raspberrypi/linux that referenced this issue Apr 7, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit to raspberrypi/linux that referenced this issue Apr 16, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit to raspberrypi/linux that referenced this issue Apr 16, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit to raspberrypi/linux that referenced this issue Apr 27, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit to raspberrypi/linux that referenced this issue May 4, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit to raspberrypi/linux that referenced this issue May 11, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit to raspberrypi/linux that referenced this issue May 20, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit to raspberrypi/linux that referenced this issue May 20, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit to raspberrypi/linux that referenced this issue Jun 3, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
jpuhlman pushed a commit to MontaVista-OpenSourceTechnology/linux-mvista that referenced this issue Jun 8, 2020
Source: kernel.org
MR: 103889
Type: Enhancement
Disposition: Merged from https://github.com/raspberrypi/linux.git rpi-5.4.y
ChangeID: 1a297e684b880c1c2c201acc7aad2409736512c5
Description:

See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
popcornmix pushed a commit to raspberrypi/linux that referenced this issue Jun 10, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit to raspberrypi/linux that referenced this issue Jun 17, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit to raspberrypi/linux that referenced this issue Jun 26, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit to raspberrypi/linux that referenced this issue Jul 1, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
popcornmix pushed a commit to raspberrypi/linux that referenced this issue Jul 13, 2020
See: raspberrypi/firmware#1311

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants