-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rpi4 eth_led0 set to 4, amber light stays on #1311
Comments
Can you point to the docs that are wrong? |
Just to confirm your changes are actually taking affect, do the other values do what you expect? |
Using this is
The eth leds are both active (green blinking, amber constant), the others 2 are behaving as expected from the config. |
Is there a logfile to know if the changes take effect? act_led_trigger=cpu works as it should but pwr_led_trigger=cpu keeps the LED on constantly |
This issue is about the eth_led parameters - please create a new issue for any other LED parameter problems (they are likely to have a different cause).
|
|
These parameters were only added in kernel 4.19.83 - if your kernel is older then you will have to update (or wait for the update to become available - I'm not sure which is the latest Raspbian kernel). |
Confirmed for me. Current kernel is version 4.19.75, upgrade to a version after .83 switched the lights off. |
I've now been able to upgrade to 4.19.93-v7l+ The eth_led0, eth_led1 Pi4 settings don't work as documented. |
Show us your config.txt file. |
dtparam=eth_led0=4 The comments are also hard to decipher (e.g. what's the difference between 0, 2, and 7?): Pi4
|
With your settings the test Pi4 on my desk has the green LED off and the orange LED flashing with activity. What do you see?
My understanding is:
It looks like 2 is mislabelled and should just say |
The data we had on this was extremely sketchy - seems very likely I have got some terminology wrong in the docs. |
The datasheet isn't at all clear. |
Ok, so according to pelwell's test, 'led_0' is green and 'led_1' is amber. Opposite to the 'usual' statement in the README file. |
You haven't yet said what you observed, just that it didn't work "as documented". Are we talking about total failure or a few inconsistencies? |
It's ok. 'led_0' is green and 'led_1' is amber. |
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The overlay README has been updated - see raspberrypi/linux@f6e7d78. |
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
See: raspberrypi/linux#3434 kernel: adds LED OFF feature to HiFiBerry DAC+ADC sound card See: raspberrypi/linux#3435 kernel: adds LED OFF feature to HiFiBerry DAC+/DAC+PRO sound cards See: raspberrypi/linux#3436 kernel: fix master mode settings of HiFiBerry DAC+ADC PRO card See: raspberrypi/linux#3424 kernel: pisound: Added reading Pisound board hardware revision and exposing it See: raspberrypi/linux#3425 kernel: Fix i2c-pwm-pca9685a overlay See: raspberrypi/linux#3431 kernel: tty: amba-pl011: Add un/throttle support kernel: tty: amba-pl011: Avoid rare write-when-full error See: #1150 kernel: ARM: dts: Declare RPi 4B SD card power regulator kernel: usb: xhci: Raspberry Pi FW loader for VIA VL805 kernel: overlays: Correct the eth_led* colour assignments See: #1311 kernel: overlays: Remove hack from uart0 overlay See: raspberrypi/linux#2856 kernel: ARM: dts: Add sd_poll_once dtparam to bcm283x/2711 See: raspberrypi/linux#3286 firmware: isp/tuner: Resetting to a lamp mode cancels manual_gains_used_ firmware: board_info: Fix uninitialised phy_addr handling in network boot firmware: IL video_decode: Default to H264 as MPEG4 isn't supported firmware: IL egl_render: Fail the create on Pi4 firmware: arm_dispmanx: Column pitch for YUV10COL is in lines not bytes firmware: platform: 2711: Also add chicken bits to dvfs voltage firmware: MMAL / video_render: Allow column stride to be set on column formats firmware: vc_image/video_decode: Move +16 lines for di_adv from vc_image to decoder
See: raspberrypi/linux#3434 kernel: adds LED OFF feature to HiFiBerry DAC+ADC sound card See: raspberrypi/linux#3435 kernel: adds LED OFF feature to HiFiBerry DAC+/DAC+PRO sound cards See: raspberrypi/linux#3436 kernel: fix master mode settings of HiFiBerry DAC+ADC PRO card See: raspberrypi/linux#3424 kernel: pisound: Added reading Pisound board hardware revision and exposing it See: raspberrypi/linux#3425 kernel: Fix i2c-pwm-pca9685a overlay See: raspberrypi/linux#3431 kernel: tty: amba-pl011: Add un/throttle support kernel: tty: amba-pl011: Avoid rare write-when-full error See: raspberrypi/firmware#1150 kernel: ARM: dts: Declare RPi 4B SD card power regulator kernel: usb: xhci: Raspberry Pi FW loader for VIA VL805 kernel: overlays: Correct the eth_led* colour assignments See: raspberrypi/firmware#1311 kernel: overlays: Remove hack from uart0 overlay See: raspberrypi/linux#2856 kernel: ARM: dts: Add sd_poll_once dtparam to bcm283x/2711 See: raspberrypi/linux#3286 firmware: isp/tuner: Resetting to a lamp mode cancels manual_gains_used_ firmware: board_info: Fix uninitialised phy_addr handling in network boot firmware: IL video_decode: Default to H264 as MPEG4 isn't supported firmware: IL egl_render: Fail the create on Pi4 firmware: arm_dispmanx: Column pitch for YUV10COL is in lines not bytes firmware: platform: 2711: Also add chicken bits to dvfs voltage firmware: MMAL / video_render: Allow column stride to be set on column formats firmware: vc_image/video_decode: Move +16 lines for di_adv from vc_image to decoder
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Source: kernel.org MR: 103889 Type: Enhancement Disposition: Merged from https://github.com/raspberrypi/linux.git rpi-5.4.y ChangeID: 1a297e684b880c1c2c201acc7aad2409736512c5 Description: See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org> Signed-off-by: Corey Minyard <cminyard@mvista.com>
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
See: raspberrypi/firmware#1311 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Latest Rasbian on Pi4, eth_led0 setting to 4 does not function as documented. Amber LED stays on.
The text was updated successfully, but these errors were encountered: