-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdtweak poll_once doesn't work on Pi 4 #3286
Comments
The immediate cause of sdtweak's failure to set the non-removable flag on pi4 is that it isn't meant to:
What is needed is a generic Perhaps what is really needed, in addition to |
can this be resolved, please? |
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
I've pushed updated .dts files to rpi-4.19.y that add sd_poll_once dtparams to all downstream .dtbs. You can grab a pre-built version of bcm2711-rpi-4-b.dtb here. Use with |
See: raspberrypi/linux#3434 kernel: adds LED OFF feature to HiFiBerry DAC+ADC sound card See: raspberrypi/linux#3435 kernel: adds LED OFF feature to HiFiBerry DAC+/DAC+PRO sound cards See: raspberrypi/linux#3436 kernel: fix master mode settings of HiFiBerry DAC+ADC PRO card See: raspberrypi/linux#3424 kernel: pisound: Added reading Pisound board hardware revision and exposing it See: raspberrypi/linux#3425 kernel: Fix i2c-pwm-pca9685a overlay See: raspberrypi/linux#3431 kernel: tty: amba-pl011: Add un/throttle support kernel: tty: amba-pl011: Avoid rare write-when-full error See: #1150 kernel: ARM: dts: Declare RPi 4B SD card power regulator kernel: usb: xhci: Raspberry Pi FW loader for VIA VL805 kernel: overlays: Correct the eth_led* colour assignments See: #1311 kernel: overlays: Remove hack from uart0 overlay See: raspberrypi/linux#2856 kernel: ARM: dts: Add sd_poll_once dtparam to bcm283x/2711 See: raspberrypi/linux#3286 firmware: isp/tuner: Resetting to a lamp mode cancels manual_gains_used_ firmware: board_info: Fix uninitialised phy_addr handling in network boot firmware: IL video_decode: Default to H264 as MPEG4 isn't supported firmware: IL egl_render: Fail the create on Pi4 firmware: arm_dispmanx: Column pitch for YUV10COL is in lines not bytes firmware: platform: 2711: Also add chicken bits to dvfs voltage firmware: MMAL / video_render: Allow column stride to be set on column formats firmware: vc_image/video_decode: Move +16 lines for di_adv from vc_image to decoder
See: raspberrypi/linux#3434 kernel: adds LED OFF feature to HiFiBerry DAC+ADC sound card See: raspberrypi/linux#3435 kernel: adds LED OFF feature to HiFiBerry DAC+/DAC+PRO sound cards See: raspberrypi/linux#3436 kernel: fix master mode settings of HiFiBerry DAC+ADC PRO card See: raspberrypi/linux#3424 kernel: pisound: Added reading Pisound board hardware revision and exposing it See: raspberrypi/linux#3425 kernel: Fix i2c-pwm-pca9685a overlay See: raspberrypi/linux#3431 kernel: tty: amba-pl011: Add un/throttle support kernel: tty: amba-pl011: Avoid rare write-when-full error See: raspberrypi/firmware#1150 kernel: ARM: dts: Declare RPi 4B SD card power regulator kernel: usb: xhci: Raspberry Pi FW loader for VIA VL805 kernel: overlays: Correct the eth_led* colour assignments See: raspberrypi/firmware#1311 kernel: overlays: Remove hack from uart0 overlay See: raspberrypi/linux#2856 kernel: ARM: dts: Add sd_poll_once dtparam to bcm283x/2711 See: raspberrypi/linux#3286 firmware: isp/tuner: Resetting to a lamp mode cancels manual_gains_used_ firmware: board_info: Fix uninitialised phy_addr handling in network boot firmware: IL video_decode: Default to H264 as MPEG4 isn't supported firmware: IL egl_render: Fail the create on Pi4 firmware: arm_dispmanx: Column pitch for YUV10COL is in lines not bytes firmware: platform: 2711: Also add chicken bits to dvfs voltage firmware: MMAL / video_render: Allow column stride to be set on column formats firmware: vc_image/video_decode: Move +16 lines for di_adv from vc_image to decoder
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Source: kernel.org MR: 103889 Type: Enhancement Disposition: Merged from https://github.com/raspberrypi/linux.git rpi-5.4.y ChangeID: abbd782ecdafba3ab6823faddfff3ad0d7b1d34d Description: The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: raspberrypi/linux#3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org> Signed-off-by: Corey Minyard <cminyard@mvista.com>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
After using |
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The old sdtweak overlay allowed the SD interface to be effectively disabled unless there was a card present at boot time, but that overlay doesn't work on bcm2711 and has largely been replaced by a set of sd_* dtparams (which have the advantage of being board- specific. Add an sd_poll_once dtparam to allow the same functionality on all Raspberry Pi boards. See: #3286 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Hi @pelwell you pushed a build to Google Drive back in January that fixed this issue. Any chance you can post the patch here? |
As the sdtweak documentation says, the functionality it provides is now available via the board-specific dtparams:
sdtweak is effectively deprecated, and will be formally deprecated and removed. |
Hi, I am hoping you can help me with a problem similar to the one in this thread. I have a PI 4B and am experiencing a kworker that hogs the cpu only when using WIFI. I have updated the kernel to 5.10.16-v7l+ and added "dtparam=sd_poll_once=on" to config.txt. I have verified that "sd_poll_once" is active using "dtc -I fs /proc/device-tree" which shows "sd_poll_once = "\0\0\0?non-removable?";". None of these changes fixed the problem. Using top the the first two lines are: 1387 root 20 0 0 0 0 I 21.6 0.0 0:16.66 kworker/u8:2-brcmf_wq/mmc1:0001:1 The offending kworker always shows as "kworker/u8:2-brcmf_wq/mmc1:0001:1" with the number after "/u8:" changing between 2, 3, and 4. Also the number is followed alternately by "+" and "-" (ie: "u8:2+brcmf" and "u8:2-brcmf"). The process "vhusbdarmpi4" is running as a service started by systemd, it is communicating via WIFI and is running a USBIP protocol. If I use a wired connection instead of WIFI the kworker disappears and the service runs as expected. Thanks, Steve |
Please start a new thread for a new issue. |
I have observed that the patch to insert the |
When network booting a pi for with
dtoverlay=sdtweak,poll_once
, the card is still polled, causing log spam every 10 seconds:The text was updated successfully, but these errors were encountered: