[3/N][CI] Replace lint CI with pre-commit #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
MortalHappiness
force-pushed
the
feature/replace-ci-pre-commit
branch
from
ad9eaba
to
d673d21
Compare
4 tasks
MortalHappiness
changed the title
MortalHappiness
force-pushed
the
feature/replace-ci-pre-commit
branch
from
d673d21
to
044e09c
Compare
|
CI failed. Will rebase with the master branch help? |
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
MortalHappiness
force-pushed
the
feature/replace-ci-pre-commit
branch
from
044e09c
to
7cdf598
Compare
CI passed after rebasing to the master branch. |
4 tasks
kevin85421
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
pre-commit hooks will be the single source of truth for formatting rules. Therefore this PR replaces all linting CI with pre-commit.
Depends on #2127
Related issue number
N/A
Checks