Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4/N][Chore] Turn off golangci-lint rules except ray-operator #2138

Merged

Conversation

MortalHappiness
Copy link
Member

Why are these changes needed?

Because #2129 replaces the CI with pre-commit and #2128 adds new golangci-lint rules, the CI will fail. Therefore this PR temporarily turns off golangci-lint rules except ray-operator.

Related issue number

N/A

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@MortalHappiness MortalHappiness marked this pull request as ready for review May 11, 2024 10:31
@MortalHappiness MortalHappiness changed the title [5/N][Chore] Turn off golangci-lint rules except ray-operator [4/N][Chore] Turn off golangci-lint rules except ray-operator May 11, 2024
@kevin85421 kevin85421 merged commit 5d3d9d3 into ray-project:master May 11, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants