helm: Uncomment the disabled key for the default workergroup #543
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows comparison between boolean types, i.e. see
ray-cluster/templates/raycluster-cluster.yaml:107, where we assert:
{{- if ne .Values.worker.disabled true }}
The default setting for the default workergroup is setting disabled to
false.
Closes ray-project#537.
2 tasks
DmitriGekhtman
approved these changes
Sep 7, 2022
|
This makes sense to me. @kevin85421 I'm not entirely sure what happened here and why I can't reproduce the issue locally. We should try to modify the template so that omitting the "disabled" field works for all Helm versions. |
4 tasks
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
…ject#543) This allows comparison between boolean types, i.e. see ray-cluster/templates/raycluster-cluster.yaml:107, where we assert: {{- if ne .Values.worker.disabled true }} The default setting for the default workergroup is setting disabled to false. Closes ray-project#537.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows comparison between boolean types, i.e. see ray-cluster/templates/raycluster-cluster.yaml:107, where we assert:
The default setting for the default workergroup is now an explicit
disabled: false.Closes #537.