-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust 2018 #712
Rust 2018 #712
Conversation
Looks like 1.32 uniform paths -- you should probably use We'll need to increase the minor versions of the crates for our minimum rust policy. |
@cuviper Paths fixed It is not possible to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
However, #711 showed that windows-gnu CI is broken right now. When that's fixed, I'll probably yield to landing this PR first, then I can fix up my own conflicts.
|
||
use docopt::Docopt; | ||
use rayon; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know rustfix does this, but I think this use
is not actually needed, as rayon
should be in the crate prelude. There are a few cases of this, but I won't comment them all. Not a big deal, just something that could be cleaned up.
I cut back Windows CI with #714, so let's see how this goes... bors r+ |
Any plans to update to Rust 2021? |
@Tom1380 no specific plans, but we try to support versions of Rust for at least a year: I'm not aware of any motivating factor to press for that update. Crates are interoperable across editions. |
Converts code-base to Rust 2018 and bumps minimum version to 1.31.
Brought to you by
rustfix