Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LNG DIST ignores esEnv parameter in settings.json #224

Closed
nstansbury opened this issue Apr 6, 2023 · 2 comments · Fixed by #233, #243 or #245
Closed

LNG DIST ignores esEnv parameter in settings.json #224

nstansbury opened this issue Apr 6, 2023 · 2 comments · Fixed by #233, #243 or #245
Assignees
Labels
enhancement New feature or request fixed This issue has been fixed

Comments

@nstansbury
Copy link

Given a custom settings.[ENV].json

settings.es5.json:

{
  "appSettings": {
    "stage": {
      "clearColor": "0x00000000",
      "useImageWorker": false,
      "canvas2d": false,
      "forceTxCanvasSource": true
    },
    "debug": false,
  },
  "platformSettings": {
    "path": "./static",
    "esEnv": "es5",
    "log": false,
    "showVersion": false,
    "inspector": false,
    "lazyDestroy": false,
    "destroyOnHistoryBack": true
  }
}

The following options in package.json:

   ...
    "build:es5": "NODE_ENV=development LNG_BUILD_FOLDER=build/es5 LNG_SETTINGS_ENV=es5 lng build",
    "dist:es5": "NODE_ENV=production LNG_DIST_FOLDER=dist/es5 LNG_SETTINGS_ENV=es5 lng dist"

npm run build:es5 builds an ES5 bundle
npm run dist:es5 builds an ES6 bundle using the same json config

@uguraslan uguraslan added the enhancement New feature or request label Apr 11, 2023
@nstansbury
Copy link
Author

As this is flagged as "enhancement" Is this the expected behaviour that lng dist ignores parameters in platformSettings?

@sandeep-vedam
Copy link
Contributor

sandeep-vedam commented Apr 11, 2023

Hello @nstansbury

I appreciate you bringing this to our attention. Unfortunately, we haven't integrated support for this particular feature on our LNG dist just yet.

However, in the meantime, you can still create a dist version with es5 by using the command:

lng dist --es5

Rest assured that we are taking note of your request and we will definitely consider adding support for it in future releases. Thank you for your understanding and patience!

@uguraslan uguraslan added the fixed This issue has been fixed label May 31, 2023
@uguraslan uguraslan linked a pull request Jul 27, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed This issue has been fixed
Projects
Status: Done
3 participants