Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for getting esEnv from settings file for lng dist #233

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

sandeep-vedam
Copy link
Contributor

No description provided.

@sandeep-vedam sandeep-vedam changed the base branch from master to dev May 8, 2023 10:08
@uguraslan uguraslan linked an issue May 8, 2023 that may be closed by this pull request
Copy link
Contributor

@michielvandergeest michielvandergeest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michielvandergeest michielvandergeest merged commit 2ac5f82 into dev Jun 12, 2023
@sandeep-vedam sandeep-vedam mentioned this pull request Jun 22, 2023
2 tasks
@cidevant
Copy link
Contributor

It doesnt work

@sandeep-vedam
Copy link
Contributor Author

Hey @cidevant

Thanks for bringing this upfront.

Can you please verify this in the below branch and check If it works?
https://github.com/rdkcentral/Lightning-CLI/tree/fix/esEnv-dist

@uguraslan uguraslan mentioned this pull request Jul 27, 2023
2 tasks
@sandeep-vedam sandeep-vedam deleted the fix/dist-esenv branch March 7, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LNG DIST ignores esEnv parameter in settings.json
3 participants